about:logins login view is not wide enough
Categories
(Firefox :: about:logins, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | --- | unaffected |
firefox74 | + | verified |
firefox75 | --- | verified |
People
(Reporter: ntim, Assigned: abruere)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
I haven't checked w/ mozregression, but from the login-item.css log, bug 1597993 seems like the only bug that could have possibly regressed this.
Reporter | ||
Comment 1•5 years ago
|
||
This seems caused by the display: flex;
on .container
which has been added to make sure the footer gets pushed to the bottom of the page.
Generally, it's not a great idea to use display: flex
only to make sure the child takes up the full height (as a side-effect of align-items
being stretch
by default). height: 100%
on .column
should be more explicit and self-contained to achieve this effect :)
Comment 2•5 years ago
|
||
Once bug 1604140 lands we can simply back out bug 1597993.
Reporter | ||
Comment 3•5 years ago
|
||
[Tracking Requested - why for this release]: UI regression in about:logins, tracking it to avoid forgetting it in case bug 1604140 doesn't land in time in for Nightly 74.
Assignee | ||
Comment 4•5 years ago
|
||
Thanks :ntim, I can make the change in case bug 1604140 doesn't land in time. flex[-grow]
rule is missing on .column
, unless using simpler height
indeed.
Should bug 1597993 be reverted, we probably want to keep focus trap regression test, isolated in its own commit for this purpose.
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
I have verified this issue and is no longer reproducible on the latest Nightly 75.0a1 (Build ID: 20200211215452). Tested on Windows 10 x64, Mac 10.14 and Arch Linux x64.
- The Login view is wide and the "Edit" and "Remove" buttons are displayed in the left part of the view.
Reporter | ||
Comment 9•5 years ago
|
||
Comment on attachment 9125597 [details]
Bug 1613580 - Restore appropriate width of login view r=ntim,jaws
Beta/Release Uplift Approval Request
- User impact if declined: See comment 0
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- Have at least one login in about:logins
- Visit about:logins
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial CSS change
- String changes made/needed: None
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Comment on attachment 9125597 [details]
Bug 1613580 - Restore appropriate width of login view r=ntim,jaws
Low risk CSS patch verified on Nightly, uplift approved for 74.0b3, thanks.
Comment 11•5 years ago
|
||
bugherder uplift |
I have verified this issue and is no longer reproducible on the latest Beta 74.0b4 (Build ID: 20200216164042). Tested on Windows 10 x64, Mac 10.14 and Arch Linux x64.
- The Login view is wide and the "Edit" and "Remove" buttons are displayed in the left part of the view.
Updated•5 years ago
|
Updated•3 years ago
|
Description
•