Closed Bug 1613580 Opened 5 years ago Closed 5 years ago

about:logins login view is not wide enough

Categories

(Firefox :: about:logins, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 + verified
firefox75 --- verified

People

(Reporter: ntim, Assigned: abruere)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image image.png (deleted) —

I haven't checked w/ mozregression, but from the login-item.css log, bug 1597993 seems like the only bug that could have possibly regressed this.

This seems caused by the display: flex; on .container which has been added to make sure the footer gets pushed to the bottom of the page.

Generally, it's not a great idea to use display: flex only to make sure the child takes up the full height (as a side-effect of align-items being stretch by default). height: 100% on .column should be more explicit and self-contained to achieve this effect :)

Once bug 1604140 lands we can simply back out bug 1597993.

[Tracking Requested - why for this release]: UI regression in about:logins, tracking it to avoid forgetting it in case bug 1604140 doesn't land in time in for Nightly 74.

Thanks :ntim, I can make the change in case bug 1604140 doesn't land in time. flex[-grow] rule is missing on .column, unless using simpler height indeed.

Should bug 1597993 be reverted, we probably want to keep focus trap regression test, isolated in its own commit for this purpose.

Assignee: nobody → andy.bruere+oss
Status: NEW → ASSIGNED
Attachment #9125597 - Attachment description: Bug 1613580 - Restore appropriate width of login view r=MattN → Bug 1613580 - Restore appropriate width of login view r=ntim,jaws
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/eea4b65aa2d1 Restore appropriate width of login view r=ntim
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

I have verified this issue and is no longer reproducible on the latest Nightly 75.0a1 (Build ID: 20200211215452). Tested on Windows 10 x64, Mac 10.14 and Arch Linux x64.

  • The Login view is wide and the "Edit" and "Remove" buttons are displayed in the left part of the view.

Comment on attachment 9125597 [details]
Bug 1613580 - Restore appropriate width of login view r=ntim,jaws

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
    • Have at least one login in about:logins
    • Visit about:logins
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial CSS change
  • String changes made/needed: None
Attachment #9125597 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Depends on: 1615215

Comment on attachment 9125597 [details]
Bug 1613580 - Restore appropriate width of login view r=ntim,jaws

Low risk CSS patch verified on Nightly, uplift approved for 74.0b3, thanks.

Attachment #9125597 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this issue and is no longer reproducible on the latest Beta 74.0b4 (Build ID: 20200216164042). Tested on Windows 10 x64, Mac 10.14 and Arch Linux x64.

  • The Login view is wide and the "Edit" and "Remove" buttons are displayed in the left part of the view.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
Blocks: 1615215
No longer depends on: 1615215
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: