Open Bug 1615215 Opened 5 years ago Updated 1 year ago

Revert bug 1597993 and bug 1613580

Categories

(Firefox :: about:logins, task, P3)

Product:
Firefox
Component:
about:logins
Type:
task

Tracking

()

People

(Reporter: ntim, Unassigned)

References

Details

(Whiteboard: [passwords:tech-debt])

The fixes are no longer needed after bug 1604140, they can be reverted and the test from bug 1597993 can be kept.

Priority: -- → P2

Hi Andy, is there any chance you want to take this?

Flags: needinfo?(andy.bruere+oss)
Whiteboard: [passwords:tech-debt]
Priority: P2 → P3

Hi Matthew, sorry for my late response. I’ve just looked at this to run hg backout but it seems the files underwent many changes. With Bug 1592467 and Bug 1625967 (responsive) in particular.

It would be quite risky to revert bug 1613580 and Bug 1597993 and I’m not sure it’s worth it. After the fix of bug 1613580 reported by Tim and recent responsive changes mentioned above, minor flexbox changes introduced to fix Bug 1597993 could be preserved, don’t you think?

Flags: needinfo?(andy.bruere+oss)
No longer blocks: 1597993, 1613580
Severity: normal → --
Depends on: 1597993, 1613580
Severity: -- → N/A
You need to log in before you can comment on or make changes to this bug.