We have a shortcut from years ago that lives in treeherder for mass triggering all perf tests. This is outdated as it is talos only where the current reality is raptor. As a new developer, or one who is new to perf validation, it is fairly easy to discover the "trigger all talos jobs" in the action menu of a push- but that is most likely not what is needed.

I would like to determine:

1. should we have a quick run all perf
2. how visible should we make tools
3. how to keep this tool to be relevant (changing tests, harnesses)

I think for 1, that is a question for sheriffs. Do they use this? Do they recommend developers use this? Do they see people using this?

for 2- I would prefer to rotate towards push health and recommend the right number of retriggers as well as tests. That is a longer term view, can we do shorter term now?

for 3- even if this is in push health, it will be outdated, I think for the perf tooling team they should revisit sheriffing tools as well as developer docs/tools on a regular basis

could we get metrics on on frequently this is used?

:igoldan, can I get your feedback on this, maybe any questions answered above?

I agree that "trigger all talos jobs" is outdated & its "convenience" doesn't reflect reality anymore.
We already have the option to fuzzy select which jobs to run from Treeherder. I believe that's enough & substitutes this old button.

@team do you have other opinions?

Didn't know about this, but it sounds pretty exhaustive and I agree with Ionut.

I never used this option so feel free to remove it.

I will replace it with "Trigger Raptor suite" which should trigger a raptor minimal suite

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #0)

1. should we have a quick run all perf

Yes, but I feel that this should not run all perf tests. I like the idea of selecting appropriate perf tests based on the patches and test value. For not, I would remove the "trigger all talos jobs" from Treeherder.

2. how visible should we make tools

I think Treeherder and mach are reasonable entry points for this.

3. how to keep this tool to be relevant (changing tests, harnesses)

Could we link this with the try presets?

(In reply to Florin Strugariu [:Bebe] (needinfo me) from comment #5)

I will replace it with "Trigger Raptor suite" which should trigger a raptor minimal suite

I disagree. I'd like to move away from "Talos" and "Raptor" and towards simplifying this to "performance tests".

it might take a couple months to realistically have tests selected based on patches. Try presets seems like a great path forward.

It sounds like we should remove the current option. That would be done in treeherder:
https://github.com/mozilla/treeherder/search?q=trigger+all+talos&unscoped_q=trigger+all+talos

Is this something the perf sheriffs can submit a PR for?

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #7)

Is this something the perf sheriffs can submit a PR for?

We're not likely to get to this in Q1.

This removes the menu item and the functions called by the menu item. Is that what's wanted? Or should we just be getting rid of the menu item and leaving the backing code intact for future use?

I would vote for getting rid of both the menu and backend code

This landed.