Closed Bug 1615509 Opened 5 years ago Closed 5 years ago

Show all compatibility issues in the document

Categories

(DevTools :: Inspector: Compatibility, enhancement, P3)

enhancement

Tracking

(firefox76 fixed)

RESOLVED FIXED
Firefox 76
Tracking Status
firefox76 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(23 files, 1 obsolete file)

(deleted), image/png
Details
(deleted), video/mp4
Details
(deleted), video/mp4
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), video/mp4
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details

For now, we can see the issue of the selected element, but instead, show all issues in the document in the compatibility pane.

Attached file Bug 1615509: Hold all issues in the store. r? (obsolete) (deleted) —
Attached image 1st-prototype.png (deleted) —

Hi Victoria!
As I made 1st prototype that shows all compatibility issues in the document we are browsing.
The added information is node information that causes the issue.
Could you check please?

Flags: needinfo?(victoria)

This is looking great!

I see that the errors are being organized by element here rather than by property/value (with the "Occurrences" sections) - what's the reason for that change?

Ideally, we would also have both Selected Element and All Issues sections as seen in the latest mockup. Needinfoing Martin to make sure we're all on the same page :)

Flags: needinfo?(victoria)
Flags: needinfo?(mbalfanz)
Flags: needinfo?(daisuke)

Thank you very much, Victoria!
Oh, indeed! I had mistaken the way to show :)
I'll change to make groups by property/value.

And regarding Selected Element.
I had thought as we will show the warning on the ruleview (GSOC project), this pane will not be needed.
But yes, I also would like to know Martin's opinion :)

Flags: needinfo?(daisuke)
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Attached video with-all-issues.mp4 (deleted) —

Hi Victoria, Martin!

I have updated the UI.

  1. Show all issues with issues on a selected element together.
  2. Group issues by property/value.

And, as I attach a video, please check the interaction as well.
Thanks!

Flags: needinfo?(victoria)

Thanks Daisuke, this looks great!

I like the grouping by property/value. This should help us to reduce duplication. Regarding "selected element", I think it makes sense to have it. Once we have the inline warnings we can still decide to remove it, though I don't see a big issue in having both.

Can't wait to flip the pref on this one! 👏

Flags: needinfo?(mbalfanz)
Attached video to-youtube.mp4 (deleted) —

Hi Victoria, Martin!
I attach a new video that navigates to youtube.com.
As you can see, in the example, the time when display the first issue takes about 7 sec after navigating.
However, actually the tool is processing.
Thus, I thought we need to add something like throbber here, what do you think?
And if we need that, where do you think we should display?

Yes! This does look fantastic!

I think it's fine to keep the "Selected Element" even after we have the GSoC feature because this panel works as a complete standalone tool with all the info together.

The Accessibility panel's "Check for Issues" currently has a basic loading screen with progress bar - maybe you could borrow that for the first launch of this feature.

Flags: needinfo?(victoria)

Thank you very much for the information, Victoria!
Okay, I'll try to show the progress bar until the first issue will be displayed.

To avoid storing declarationBlocks in reducer.
The reason why I held the information is because had thought that want to update
as soon as possible when change the target browser.
However, as it seems that to update the target browser is not so frequently,
remove the information to reduce the memory.

Depends on D64305

Attached file Bug 1615509: Show all issues. (deleted) —

Depends on D64306

Depends on D64307

Depends on D64308

Depends on D64309

Attached file Bug 1615509: Add styles. (deleted) —

Depends on D64310

Depends on D64311

Depends on D64312

Depends on D64314

Depends on D64315

Depends on D64316

Depends on D64317

Depends on D64318

Attachment #9126657 - Attachment is obsolete: true

Depends on D64319

Depends on D64533

Depends on D64534

Attached video with-throbber.mp4 (deleted) —

Hi Victoria!
I have tried a throbber that also is used in the accessibility panel instead of a progress bar.
Because to know the number of processing takes more some time and be complex the mechanism a bit. And it seems this might be enough if we want to know only whether it is processing or not.
What do you think??

Flags: needinfo?(victoria)

Hi Daisuke, that looks good! I know progress bars are tricky so it makes sense to keep it simple. I'd suggest we hide the "No compatibility issues found" message as soon as the throbber appears. Otherwise, this seems great!

Flags: needinfo?(victoria)

Thank you very much for taking a look, Victoria!
Yes, I will hide the message!

Depends on D64535

Depends on D65284

Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee220b50d171 Move place where calculate the issues to the action. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/984007b00335 Hold all issues in document into the store. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/0527c1bd1b61 Show all issues. r=rcaliman,ladybenko https://hg.mozilla.org/integration/autoland/rev/b5bd9789553e Show nodes that caused the issue. r=rcaliman,ladybenko https://hg.mozilla.org/integration/autoland/rev/8284770b42b4 Add interaction feature to Rep component. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/8bb8d8146868 Address rule view change event. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/488e03cb9723 Add styles. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/146ee88fba20 Update a node test for IssueItem. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/326ea09ed737 Add an unit test for NodePane. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/96be8d39bc09 Add an unit test for NodeList. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/d4a3ac741275 Add an unit test for NodeItem. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/da84734dca0c Update test that shows css-property issues. r=mtigley https://hg.mozilla.org/integration/autoland/rev/24d5cb462667 Update test that changes selected node. r=mtigley https://hg.mozilla.org/integration/autoland/rev/d669aefdfeba Update test that checks issues after reloading. r=mtigley https://hg.mozilla.org/integration/autoland/rev/85bd4b410435 Update test that changes style on rule view. r=mtigley https://hg.mozilla.org/integration/autoland/rev/2df6831aea1a Add a test for issue node. r=mtigley https://hg.mozilla.org/integration/autoland/rev/29b2f9ef4188 Add a test for changing top level target. r=mtigley https://hg.mozilla.org/integration/autoland/rev/c6fabe2143a4 Show throbber while processing. r=mtigley,ladybenko https://hg.mozilla.org/integration/autoland/rev/c74ae992992f Add a test for the throbber. r=mtigley
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f67873989fcd Move place where calculate the issues to the action. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/5f78a5443663 Hold all issues in document into the store. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/af49cf9465dc Show all issues. r=rcaliman,ladybenko https://hg.mozilla.org/integration/autoland/rev/afdf29f4f9df Show nodes that caused the issue. r=rcaliman,ladybenko https://hg.mozilla.org/integration/autoland/rev/48a549b1e1b5 Add interaction feature to Rep component. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/4f963ee21af7 Address rule view change event. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/664ab598f651 Add styles. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/d0d42889e642 Update a node test for IssueItem. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/448b3a12fbb0 Add an unit test for NodePane. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/7e6fec746b47 Add an unit test for NodeList. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/9f36a6f85237 Add an unit test for NodeItem. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/d0547562011d Update test that shows css-property issues. r=mtigley https://hg.mozilla.org/integration/autoland/rev/be92dd7a0069 Update test that changes selected node. r=mtigley https://hg.mozilla.org/integration/autoland/rev/3c9a23c99e19 Update test that checks issues after reloading. r=mtigley https://hg.mozilla.org/integration/autoland/rev/a37e0b3c5337 Update test that changes style on rule view. r=mtigley https://hg.mozilla.org/integration/autoland/rev/597c0b19571d Add a test for issue node. r=mtigley https://hg.mozilla.org/integration/autoland/rev/6442b6dbc71d Add a test for changing top level target. r=mtigley https://hg.mozilla.org/integration/autoland/rev/c72542e3da98 Show throbber while processing. r=mtigley,ladybenko https://hg.mozilla.org/integration/autoland/rev/6b84773529d2 Add a test for the throbber. r=mtigley
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: