Closed
Bug 1616701
Opened 5 years ago
Closed 5 years ago
Fix and re-enable RDM tests that wait for viewport resize
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox75 fixed)
RESOLVED
FIXED
Firefox 75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: bradwerth, Assigned: mtigley)
References
(Blocks 2 open bugs)
Details
(Whiteboard: fission-rdm-reserve)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1585121 disabled this test due to problems modernizing it for Fission and the new RDM browser UI. The main problem seems to be that the test is not waiting for the UI to be fully initialized before running the checks -- though Bug 1585121 modified the addRDMTaskWithPreAndPost function to wait for the "post-init" message.
This bug was opened to avoid blocking the bulk of the work landing in Bug 1585121.
|
Reporter | |
Updated•5 years ago
|
Priority: -- → P3
|
|
Reporter | |
Comment 1•5 years ago
|
||
I'm generalizing this bug to cover all tests that fail on waiting for a RDM viewport resize. This could be to bad initial conditions or something else. They likely will all be fixable by addressing the same root cause.
So far, affect tests are:
- browser_device_change.js
- browser_device_state_restore.js
- browser_state_restore.js
Summary: Fix and re-enable test browser_device_change.js → Fix and re-enable RDM tests that wait for viewport resize
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Comment 4•5 years ago
|
||
This is the follow-up to bug 1585121 that needs to be part of our RDM Fission project too.
Whiteboard: fission-rdm-mvp
|
||
Updated•5 years ago
|
Priority: P3 → P1
Whiteboard: fission-rdm-mvp → fission-rdm-reserve
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd2b699108fa
Fix and re-enable tests that use waitForViewportResize and dragElementBy r=bradwerth
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
|
|
||
Updated•5 years ago
|
Depends on: dt-rdm-fission
|
|
||
Updated•5 years ago
|
Blocks: dt-rdm-fission
No longer depends on: dt-rdm-fission
You need to log in
before you can comment on or make changes to this bug.
Description
•