Open Bug 1617123 Opened 5 years ago Updated 2 years ago

[macOS] - PIP controls overlap on resize to min size

Categories

(Toolkit :: Picture-in-Picture, defect, P3)

Desktop
macOS
defect

Tracking

()

Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox81 --- wontfix
firefox82 --- wontfix
firefox83 --- wontfix

People

(Reporter: cfogel, Unassigned, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: blocked-ux, regression)

Attachments

(1 file)

Attached image Screen Shot 2020-02-21 at 11.08.48.png (deleted) —

Affected versions

  • 74.0b6, 75.0a1 (2020-02-20);

Affected platforms

  • macOS 10.11

Steps to reproduce

  1. Launch Firefox, enable PIP
  2. Access any video on Youtube
  3. Play the video in PIP
  4. Resize the PIP frame to the minimum possible size.

Expected result

  • controls are properly displayed;

Actual result

  • controls overlap with the close button;

Regression range

Additional notes

  • attached screenshot with the issue.
Has Regression Range: --- → no
Has STR: --- → yes
Blocks: videopip
Priority: -- → P3

Updated the regression section for the initial comment.
@Mike, can you please confirm if the regress-or is accurate?
Thanks!

Flags: needinfo?(mconley)
Regressed by: 1567009

Yep, sounds plausible, thanks!

Flags: needinfo?(mconley)
Has Regression Range: no → yes

Still an issue on macOS 10.15 with 82.0b5, 83.0a1(2020-10-05).
Severity could be updated to S4, due to the unlikely-hood of a normal user encountering the issue.

Component: Video/Audio Controls → Picture-in-Picture
Version: unspecified → Trunk

Hey, I would like to work on this issue.

Flags: needinfo?(mconley)

Maybe we could fix the min size to which the pip window can be resized so that controls don't overlap.

If we decide to work on this ticket, let's treat it as a part of [PiP responsiveness and graceful degradation stories(https://docs.google.com/document/d/1LteDB8JKM15RqO38LnLFwQ-egYNDnrhB5YgnypzuCzc/edit#)].

tl;dr - I think the right solution would be to remove the controls after the dimensions of the PiP window drops past threshold values.

If there's an appetite to work on this as a part of the Outreachy program, I can brush up the spec and remake this ticket into an enhancement.

Severity: minor → S4

(In reply to amininkova from comment #6)

If we decide to work on this ticket, let's treat it as a part of [PiP responsiveness and graceful degradation stories(https://docs.google.com/document/d/1LteDB8JKM15RqO38LnLFwQ-egYNDnrhB5YgnypzuCzc/edit#)].

tl;dr - I think the right solution would be to remove the controls after the dimensions of the PiP window drops past threshold values.

If there's an appetite to work on this as a part of the Outreachy program, I can brush up the spec and remake this ticket into an enhancement.

Hey, Thanks!
I would like to work on this as an outreachy applicant, and the link of the doc isn't accessible to me. Please allow me.

Flags: needinfo?(amininkova)

Hi Janvi,

My apologies for the late reaction to this. We are working on some updates for PiP controls, and that includes changing their behavior on window resizing.

I shared the document with you, but these requirements are still in flux and would take a while to congeal. I'm going to mark this ticket as ux-blocked.

Flags: needinfo?(amininkova)
Keywords: blocked-ux
Duplicate of this bug: 1824424

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

:mhowell, could you consider increasing the severity of this bug to S3?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mhowell)

I think S4 remains appropriate here.

Flags: needinfo?(mhowell)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: