Closed Bug 1617170 Opened 5 years ago Closed 5 years ago

Clean up FileInfo/FileManager

Categories

(Core :: Storage: IndexedDB, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: sg, Assigned: sg)

References

(Blocks 1 open bug)

Details

Attachments

(38 files, 6 obsolete files)

(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details

Code around FileInfo and FileManager is error-prone, including stateful and missing encapsulation. This should be cleaned up.

Priority: -- → P2
Attachment #9128127 - Attachment description: Bug 1617170 - Restrict availability of InitializedOnce::reset. r=#dom-workers-and-storage → Bug 1617170 - Restrict availability of InitializedOnce::reset, and add InitializedOnce::release. r=#dom-workers-and-storage
Keywords: leave-open
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7d7c2ac75f6 Reduce statefulness of FileManager. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/ebfdc4ae6375 Encapsulate DatabaseConnection::UpdateRefcountFunction::FileInfoEntry. r=dom-workers-and-storage-reviewers,janv
Blocks: 1584953
Attachment #9129186 - Attachment description: Bug 1617170 - Add gtests for FileInfo. → Bug 1617170 - Add gtests for FileInfo. r=#dom-workers-and-storage
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcbaa4b3dfd1 Make StoredFileInfo members const, and initialize them in the constructor. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/01ac0cc00f04 Restrict availability of InitializedOnce::reset, and add InitializedOnce::release. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fb4fd4616e7 Encapsulate StoredFileInfo members. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/45147956214d Encapsulate fields and reduce statefulness of DatabaseFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/bff4f33c1cdb Reduce statefulness of CreateFileOp. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/5a32ea526352 Rename GetNewFileInfo to CreateFileInfo. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/132e22c686d6 Encapsulate members of MutableFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/c8931f8118a0 Change signature of FileInfo::GetFileForFileInfo to accept const& instead of raw pointer. r=dom-workers-and-storage-reviewers,janv

Backed out 6 changesets for causing bustages in build/src/dom/indexedDB

Backout link: https://hg.mozilla.org/integration/autoland/rev/bc7e351c2e9e5219567b5a0089b1aeb00c0047a2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=c8931f8118a0812526de490e8008f9c8bee1d4d3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291275894&repo=autoland&lineNumber=43201

[task 2020-03-02T15:39:21.488Z] 15:39:21     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/ipc'
[task 2020-03-02T15:39:21.665Z] 15:39:21     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/indexedDB'
[task 2020-03-02T15:39:21.665Z] 15:39:21     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o ActorsParent.o -c  -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/workspace/build/src/dom/indexedDB -I/builds/worker/workspace/build/src/obj-firefox/dom/indexedDB -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/storage -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/third_party/sqlite3/src -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow  -MD -MP -MF .deps/ActorsParent.o.pp   /builds/worker/workspace/build/src/dom/indexedDB/ActorsParent.cpp
[task 2020-03-02T15:39:21.666Z] 15:39:21    ERROR -  /builds/worker/workspace/build/src/dom/indexedDB/ActorsParent.cpp:7568:58: error: declaration of 'const mozilla::dom::indexedDB::FileInfo& mozilla::dom::indexedDB::{anonymous}::ObjectStoreAddOrPutRequestOp::StoredFileInfo::FileInfo() const' [-fpermissive]
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -     const FileInfo& FileInfo() const { return **mFileInfo; }
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -                                                            ^
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -  In file included from /builds/worker/workspace/build/src/dom/indexedDB/ActorsParent.cpp:13:0:
[task 2020-03-02T15:39:21.666Z] 15:39:21    ERROR -  /builds/worker/workspace/build/src/dom/indexedDB/FileInfo.h:18:7: error: changes meaning of 'FileInfo' from 'class mozilla::dom::indexedDB::FileInfo' [-fpermissive]
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -   class FileInfo final {
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -         ^~~~~~~~
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -  /builds/worker/workspace/build/src/config/rules.mk:745: recipe for target 'ActorsParent.o' failed
[task 2020-03-02T15:39:21.666Z] 15:39:21    ERROR -  make[4]: *** [ActorsParent.o] Error 1
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/indexedDB'
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -  make[4]: *** Waiting for unfinished jobs....
[task 2020-03-02T15:39:21.666Z] 15:39:21     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/ipc'
[task 2020-03-02T15:39:21.667Z] 15:39:21     INFO -  layout/ipc/VsyncParent.o
Flags: needinfo?(sgiesecke)

Fixed gcc build bustage. clang doesn't complain about that, interestingly. However, there was another editing error also affecting clang builds. Re-landing now.

Flags: needinfo?(sgiesecke)
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c0b58478587 Encapsulate StoredFileInfo members. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/8d916af11b79 Encapsulate fields and reduce statefulness of DatabaseFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/93caccc81c98 Reduce statefulness of CreateFileOp. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/c0395ed8e6cc Rename GetNewFileInfo to CreateFileInfo. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/8327e780e3c6 Encapsulate members of MutableFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/d748f4a50eda Change signature of FileInfo::GetFileForFileInfo to accept const& instead of raw pointer. r=dom-workers-and-storage-reviewers,janv

I thought I had tested that, but apparently I mixed something up. https://treeherder.mozilla.org/#/jobs?repo=try&revision=82babf55d739bf46a3a28eb358ff3991967fcf79 is now running, and if that's fine, I will re-land.

Flags: needinfo?(sgiesecke)
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1ed2f2fcdfb Encapsulate StoredFileInfo members. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/41f56e8d0a03 Encapsulate fields and reduce statefulness of DatabaseFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/7a83b0348c4a Reduce statefulness of CreateFileOp. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/448d9723a425 Rename GetNewFileInfo to CreateFileInfo. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/f8a89a7cf897 Encapsulate members of MutableFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/b16772537144 Change signature of FileInfo::GetFileForFileInfo to accept const& instead of raw pointer. r=dom-workers-and-storage-reviewers,janv

Depends on D65548

Depends on D65549

Depends on D65550

Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88adb68ecff5 Use nsBaseHashtable::RemoveIf function in dom/indexedDB code. r=dom-workers-and-storage-reviewers,asuth
Attachment #9130742 - Attachment description: Bug 1617170 - Remove duplication around deleting files. r=#dom-workers-and-storage,janv → Bug 1617170 - Remove duplication around deleting files. r=#dom-workers-and-storage,asuth
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f1a4f3952931 Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/90dfe1253fe4 Use Variant in StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/5d3ed69aca66 Remove mysteriously named ResolveMysteryMutableFile function. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/bda38a16aac3 Extracted common WrapAsJSObject function. r=dom-workers-and-storage-reviewers,perry https://hg.mozilla.org/integration/autoland/rev/cc2aadaf5923 Replace sequence of ifs by switch. r=dom-workers-and-storage-reviewers,janv
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/494b93cf87a0 Backed out 5 changesets for toolchains bustages CLOSED TREE
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6acafdd56175 Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/2ae6b424f492 Use Variant in StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/51c699b06d04 Remove mysteriously named ResolveMysteryMutableFile function. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/739dafac70bc Extracted common WrapAsJSObject function. r=dom-workers-and-storage-reviewers,perry https://hg.mozilla.org/integration/autoland/rev/c9561cb90821 Replace sequence of ifs by switch. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/92f4ef8809ec Remove output parameter on GetStructuredCloneReadInfo* function, use Result instead. r=dom-workers-and-storage-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/0021ab4bcf77 Added const at a few places. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/ed7eaba53757 Unfriend FileInfo from FileManager and encapsulate access to mFileInfos. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62cddf341d1e Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/163e89015b83 Use Variant in StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/e701761075df Remove mysteriously named ResolveMysteryMutableFile function. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/955f6482ff72 Extracted common WrapAsJSObject function. r=dom-workers-and-storage-reviewers,perry https://hg.mozilla.org/integration/autoland/rev/a74e47ef8215 Replace sequence of ifs by switch. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/1d24fc48bfde Remove output parameter on GetStructuredCloneReadInfo* function, use Result instead. r=dom-workers-and-storage-reviewers,asuth https://hg.mozilla.org/integration/autoland/rev/9c1f7142cd12 Added const at a few places. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/466957b35672 Unfriend FileInfo from FileManager and encapsulate access to mFileInfos. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/9ac9c80edf1f Replace GetFileReferencesHelper class by DispatchAndReturnFileReferences function. r=dom-workers-and-storage-reviewers,janv

I worked around the gcc issue (and opened Bug 1620632 to fix the cause of that), and also fixed the issue on Windows builds. I hope the patches are finally good now :)

Flags: needinfo?(sgiesecke)
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1de268b3e1df Move DECLARE_USE_COPY_CONSTRUCTORS for StructuredCloneReadInfo to dom/indexedDB/IndexedDatabase.h r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/2c6e584035d0 Encapsulate StructuredCloneReadInfo members. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/9509d461a14a Removed duplication in Helper::Invalidate* functions. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/1e2b49c7917f Split StructuredCloneReadInfo into parent- and child-specific classes. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/63a0e3bc3541 Remove some local helper classes. r=dom-workers-and-storage-reviewers,janv
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ece415a05ec0 Make GetFileForFileInfo a non-static member function. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/fc8810675443 Get rid of CustomCleanupCallback and replace by call into FileManager. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/6fac755f3fd4 Make AsyncDeleteFile a member function of FileManager. r=janv,dom-workers-and-storage-reviewers https://hg.mozilla.org/integration/autoland/rev/361657ebc6bc Pull up parts of FileManager that are used by FileInfo into FileManagerBase. r=janv,dom-workers-and-storage-reviewers

Depends on D65948

Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88e0ee779bb2 Fix non-unified build. r=janv,dom-workers-and-storage-reviewers https://hg.mozilla.org/integration/autoland/rev/02efb0a3a615 Make FileInfo more testable by removing the dependency on FileManager. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/d2fd55085272 Remove unused slice ref-count. r=dom-workers-and-storage-reviewers,janv https://hg.mozilla.org/integration/autoland/rev/9c561323b07e Move implementation of CommonStructuredCloneReadCallback to IndexedDatabase.cpp r=janv,dom-workers-and-storage-reviewers

Comment on attachment 9131145 [details]
Bug 1617170 - Use SafeRefPtr for FullDatabaseMetadata. r=#dom-workers-and-storage

Revision D65548 was moved to bug 1623278. Setting attachment 9131145 [details] to obsolete.

Attachment #9131145 - Attachment is obsolete: true

Comment on attachment 9131146 [details]
Bug 1617170 - Use SafeRefPtr for FileManager. r=#dom-workers-and-storage

Revision D65549 was moved to bug 1623278. Setting attachment 9131146 [details] to obsolete.

Attachment #9131146 - Attachment is obsolete: true

Comment on attachment 9131147 [details]
Bug 1617170 - Use SafeRefPtr for FileInfo. r=#dom-workers-and-storage

Revision D65550 was moved to bug 1623278. Setting attachment 9131147 [details] to obsolete.

Attachment #9131147 - Attachment is obsolete: true

Comment on attachment 9131181 [details]
Bug 1617170 - Use SafeRefPtr for Database. r=#dom-workers-and-storage

Revision D65568 was moved to bug 1623278. Setting attachment 9131181 [details] to obsolete.

Attachment #9131181 - Attachment is obsolete: true

Comment on attachment 9131441 [details]
Bug 1617170 - Use SafeRefPtr for TransactionBase and its subclasses. r=#dom-workers-and-storage

Revision D65711 was moved to bug 1623278. Setting attachment 9131441 [details] to obsolete.

Attachment #9131441 - Attachment is obsolete: true

Comment on attachment 9133561 [details]
Bug 1617170 - Use SafeRefPtr for IDBFactory. r=#dom-workers-and-storage

Revision D66972 was moved to bug 1623278. Setting attachment 9133561 [details] to obsolete.

Attachment #9133561 - Attachment is obsolete: true
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23b42017cf7d Add gtests for FileInfo. r=dom-workers-and-storage-reviewers,janv
Backout by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d19968c99a7 Backed out changeset 23b42017cf7d for build bustage at indexedDB/test/gtest/TestFileInfo.cpp on a CLOSED TREE

This is due to a bug in clang: https://bugs.llvm.org/show_bug.cgi?id=21629

Unfortunately, using double braces as a workaround prevents template argument deduction. This is the current version, which clang 5 does not accept:

  static constexpr auto kDBOnlyFileInfoIds =
      std::array{int64_t(10), int64_t(20), int64_t(30)};

This is no valid C++:

  static constexpr auto kDBOnlyFileInfoIds =
      std::array{{int64_t(10), int64_t(20), int64_t(30)}};

So I need to write:

  static constexpr auto kDBOnlyFileInfoIds =
      std::array<int64_t, 3>{{10, 20, 30}};

I hope that clang 5 accepts that.

Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fe8b7c7b315 Add gtests for FileInfo. r=dom-workers-and-storage-reviewers,janv
Attachment #9131839 - Attachment description: Bug 1617170 - Added comments. → Bug 1617170 - Deserialize Blob only when it is used in AllocPBackgroundIDBDatabaseFileParent. r=#dom-workers-and-storage
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6df7028b41d0 Reduce statefulness of FileHelper. r=janv,dom-workers-and-storage-reviewers https://hg.mozilla.org/integration/autoland/rev/11d9ccb4ddd8 Deserialize Blob only when it is used in AllocPBackgroundIDBDatabaseFileParent. r=janv https://hg.mozilla.org/integration/autoland/rev/5abef9862e60 Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers
Keywords: leave-open
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a880c8cc014e Reduce statefulness of FileHelper. r=janv,dom-workers-and-storage-reviewers https://hg.mozilla.org/integration/autoland/rev/bdbbe1018985 Deserialize Blob only when it is used in AllocPBackgroundIDBDatabaseFileParent. r=janv https://hg.mozilla.org/integration/autoland/rev/74465a508e6c Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers https://hg.mozilla.org/integration/autoland/rev/026c69cf6e3a Remove duplication around deleting files. r=janv,dom-workers-and-storage-reviewers
Blocks: IndexedDB-SM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: