Closed
Bug 1620273
Opened 5 years ago
Closed 5 years ago
Add SafeRefPtr as a safer variant of a RefPtr
Categories
(Core :: Storage: IndexedDB, task, P2)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Add a safe variant of a RefPtr
, which prohibits some unsafe or
unperformant misuses, in particular:
- It is not implicitly convertible from a raw pointer. Unsafe acquisitions
from a raw pointer must be made using the verbose
AcquireStrongRefFromRawPtr. - It does not implicitly decay to a raw pointer. get() must be called
explicitly. - It is not copyable, but must be explicitly copied using clone().
- Temporaries cannot be dereferenced using operator* or operator->.
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D65306
Updated•5 years ago
|
Attachment #9131144 -
Attachment description: Bug 1620273 - Add SafeRefPtr. r=#dom-workers-and-storage,asuth → Bug 1620273 - Add SafeRefPtr. r=#dom-workers-and-storage
Assignee | ||
Updated•5 years ago
|
Priority: -- → P2
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d69cf5fcb571
Add SafeRefPtr. r=asuth,dom-workers-and-storage-reviewers
Comment 3•5 years ago
|
||
Backed out 10 changesets (Bug 1623278, Bug 1617170, Bug 1620273, Bug 1597954) for causing bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/0e7e76826ace75277a1f892dc14358c675d1c911
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293829628&repo=autoland&lineNumber=45369
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bcd8d19b32c
Add SafeRefPtr. r=asuth,dom-workers-and-storage-reviewers
Comment 5•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•