Closed
Bug 1618525
Opened 5 years ago
Closed 5 years ago
about:logins - remove hover effect for [Sort by] login-sort dropdown button if it is disabled
Categories
(Firefox :: about:logins, defect)
Firefox
about:logins
Tracking
()
VERIFIED
FIXED
Firefox 75
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox73 | --- | wontfix |
| firefox74 | --- | wontfix |
| firefox75 | --- | verified |
People
(Reporter: cfogel, Assigned: itiel_yn8)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
hoverAbout.gif
Affected versions
- 73.0.1, 74.0b8, 75.0a1 (2020-02-27);
Affected platforms
- Windows 10, macOS 10.15, Ubuntu 18.04;
Steps to reproduce
- Launch Firefox, access about:logins
- Remove all the logins if any;
- Hover over the Name (A-Z) button;
Expected result
- UX-wise - nothing should happen, button is disabled;
Actual result
- hover effect triggered on both light/dark theme;
Regression range
- Pushlog: URL
- Introduced with: 1584162;
Additional notes
- attached recording with the issue;
|
||
Comment 1•5 years ago
|
||
Type: enhancement → defect
This seems easy to fix, just add a :not([disabled]) selector here:
https://searchfox.org/mozilla-central/rev/a69f60390921e21e1d62d40ce388c44a71db00c6/browser/components/aboutlogins/content/components/login-list.css#35
Flags: needinfo?(itiel_yn8)
|
|
||
Updated•5 years ago
|
Keywords: regression
|
||
Updated•5 years ago
|
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/e1ed4b83448f
Don't apply the hover effect on the login-sort dropdown button if there are no logins r=MattN
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
Verified the issue with Firefox Nightly 75.0a1 (2020-03-05) on Windows 10 x64, Ubuntu 18.04 and mac OS 10.15, it is no longer reproducible.
|
Reporter | |
Comment 7•5 years ago
|
||
Awesome, thank you for your input!
Updating the bug-status as well.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•