clang-format Refresh the tree once clang-format 10 is live
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(firefox77 fixed)
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
https://reviews.llvm.org/D69573 will ship with clang-10 and introduces some changes in our code base.
- operator Rooted<T>&() { return *savedRoot; }
+ operator Rooted<T> &() { return *savedRoot; }
or
- operator const nsIFrame*() const { return mFrame; }
+ operator const nsIFrame *() const { return mFrame; }
Nothing too fancy
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
This change doesn't make sense to me, considering we're preferring the form nsIFrame* frame to nsIFrame *frame.
|
|
||
Comment 2•5 years ago
|
||
The LLVM patch even looks like it respects PointerAlignment, and that it shouldn't make a difference for PointerAlignment = Left (which is what we have).
|
|
Assignee | |
Comment 3•5 years ago
|
||
I forgot to give links to the upstream changes.
https://reviews.llvm.org/D69573
and a regression fix:
https://reviews.llvm.org/D72911
(not in 10.0rc2)
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
I reported upstream two regressions:
https://bugs.llvm.org/show_bug.cgi?id=45357
https://bugs.llvm.org/show_bug.cgi?id=45358
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 8•5 years ago
|
||
ignore-this-changeset
|
|
||
Comment 9•5 years ago
|
||
Comment on attachment 9144842 [details]
Bug 1619165 - Reformat recent changes to the Google coding style r=andi
Revision D73347 was moved to bug 1519636. Setting attachment 9144842 [details] to obsolete.
|
||
Updated•2 years ago
|
Description
•