Closed Bug 1625884 Opened 5 years ago Closed 5 years ago

Update clang-tools to version 10

Categories

(Firefox Build System :: Toolchains, task)

task
Not set
normal

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: Sylvestre, Assigned: andi)

References

(Blocks 1 open bug)

Details

Attachments

(5 files, 3 obsolete files)

Currently, we are using clang-9.0.1

Assignee: sledru → nobody
Blocks: 1619165
Assignee: nobody → bpostelnicu

Is there any risk of developer "surprises" (CI bustage that didn't appear locally) if we do this without updating the main clang toolchain to version 10?

(In reply to :dmajor from comment #2)

Is there any risk of developer "surprises" (CI bustage that didn't appear locally) if we do this without updating the main clang toolchain to version 10?

for clang-tidy package, including clang-format the negative impact non-existent, I'm testing this now to be sure we don't regress with anything.

I have been able to reformat the tree with clang-format-10 in bug 1619165
(not super happy about the change but it works)

For building macosx64-clang-tidy with linux64-clang-10 we need to build cctools
with clang-10.

Depends on D70063

Depends on D70064

In order to prepare for the migration to clang-10 we also add the following targets:

  • linux64-clang-10-cross
  • linux64-clang-10-android-cross
  • linux64-clang-10-aarch64-cross
  • linux64-clang-10-macosx-cross
  • linux64-clang-10-win-cross

Depends on D70065

Blocks: 1466070
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/927ff250bc4b add `clang-10` to `linux64` `clang-tools`. r=nalexander,dmajor https://hg.mozilla.org/integration/autoland/rev/412c8c401196 add target `linux64-cctools-clang-10-port`. r=nalexander https://hg.mozilla.org/integration/autoland/rev/a35cfda6e271 move `clang-tidy` and `clang-format` to `clang-10`. r=nalexander
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla77 → ---

Backed out changeset a35cfda6e271 (bug 1625884)
Backed out changeset 412c8c401196 (bug 1625884)
Backed out changeset 927ff250bc4b (bug 1625884)

Attachment #9139468 - Attachment is obsolete: true
Attachment #9138908 - Attachment is obsolete: true

Backed out changeset a35cfda6e271 (bug 1625884)
Backed out changeset 412c8c401196 (bug 1625884)
Backed out changeset 927ff250bc4b (bug 1625884)

Attachment #9139575 - Attachment is obsolete: true
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a97ea3443ded add `clang-10` to `linux64` `clang-tools`. r=nalexander,dmajor https://hg.mozilla.org/integration/autoland/rev/d9e8bf80cefd add target `linux64-cctools-clang-10-port`. r=nalexander https://hg.mozilla.org/integration/autoland/rev/a10480b9cf16 move `clang-tidy` and `clang-format` to `clang-10`. r=nalexander
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Backed out changeset a35cfda6e271 (bug 1625884)
Backed out changeset 412c8c401196 (bug 1625884)
Backed out changeset 927ff250bc4b (bug 1625884)

This patch adds the support to use nss functions
in rlbox wasm sandbox. This enables the use of
Prio as a sandboxed lib for Firefox.

Depends on D70701

(In reply to shivambalikondwar from comment #17)

Created attachment 9140170 [details]
Bug 1625884 - [WIP]: Change third_party/prio for rlbox sandboxing.

This patch adds the support to use nss functions
in rlbox wasm sandbox. This enables the use of
Prio as a sandboxed lib for Firefox.

Depends on D70701

I think you've updated the wrong bug.

Regressions: 1680126
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: