Closed
Bug 1620453
Opened 5 years ago
Closed 5 years ago
Properly promote unexpected plugin wmode values to direct on Windows
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Tracking
(firefox76 fixed)
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: handyman, Assigned: handyman)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The only wmode values that we should send to Flash Player (on Windows) are "direct", "opaque" and "transparent". Any other values are either out of date or illegal. In particular, we want "window" and "gpu" modes (as well as any unexpected values such as "default" or "foo") to be promoted to "direct" by Firefox. We handle "window" and "gpu" correctly, but not the rest. This bug is to change ForceDirect [1] to fix that.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
This code always intended to force wmode to be one of these modes (bug 1340276) but was not robust to unexpected wmode values (e.g. "default"). Unexpected values are now promoted to "direct".
|
|
Assignee | |
Comment 2•5 years ago
|
||
The wmode behavior is explained here: https://wiki.mozilla.org/Plugins/Async_Drawing#Windows
|
||
Updated•5 years ago
|
Flags: needinfo?(aklotz)
Pushed by daparks@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de94a3c40ad2
Force Windows plugin wmode to be direct, opaque or transparent r=aklotz
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•