Closed Bug 1621331 Opened 5 years ago Closed 4 years ago

Stop styling <select multiple> like buttons in non-native theme

Categories

(Core :: Widget, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

This uncovered a test bug in bug 1621319, but I think I agree with markus on the review that there's a lot of padding.

Flags: needinfo?(shorlander)

I think we should just stop styling <select multiple> like we style buttons... It shouldn't have any hover or active state or padding, like listboxes on most platforms.

Summary: Consider reducing padding on <select multiple> in the non-native theme. → Stop styling <select multiple> like buttons
Summary: Stop styling <select multiple> like buttons → Stop styling <select multiple> like buttons in non-native theme

I haven't requested review because the patch needs a rebase, and also because using the PaintTextField function isn't particularly great (even if it gets us closer to looking like a listbox).

Attachment #9135584 - Attachment is obsolete: true

This has been fixed elsewhere I think.

Emilio, can you confirm if your original bug was fixed and close this? Thanks!

Flags: needinfo?(stephen) → needinfo?(emilio)

Yeah, this was fixed in bug 1640195.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(emilio)
Resolution: --- → FIXED
Attached image select-multiple-arrow-hover-state.png (deleted) —

I think this issue is still reproducible, see the attached screenshot (select-multiple-arrow-hover-state.png). I tested on Windows 8.1 x64 and Windows 10 x64, with pref widget.disable-native-theme-for-content = true, on Fx 86.0 and on latest nightly, access bugzilla.com website/Advanced Search for example on Classification or Status multi selection listboxes the scroll have hover state and activ state too. If the issue is not about this bug please ping me and I file a new bug. Thanks!

Flags: needinfo?(emilio)

No, that's the scrollbar arrow, which is expected to have hover styles. Before we used to apply the hover style to the whole listbox.

Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: