Address UX feedback for non-native widget styling
Categories
(Core :: Widget, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: spohl, Assigned: spohl)
References
Details
Attachments
(2 files)
I'm filing this bug so that we have a bug number to associate with a patch that addresses the latest round of UX feedback. I will be going through our backlog of bugs and close some as dupes of this bug, since it made sense to address all the UX feedback in one go and in one place. The UX feedback is captured here:
https://mozilla.invisionapp.com/share/5CX2MH6EHFB#/screens/415584863_Form_Widgets
Assignee | ||
Comment 1•4 years ago
|
||
Comment 4•4 years ago
|
||
Backed out changeset 4fbc6775e743 (Bug 1640195) for causing multiple failures CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311449690&repo=autoland&lineNumber=1693
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311452012&repo=autoland&lineNumber=22842
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311456991&repo=autoland&lineNumber=2504
Backout: https://hg.mozilla.org/integration/autoland/rev/90c6cc6b2ecb368bcc29e2f0529823e91050a28c
Comment 6•4 years ago
|
||
bugherder |
Comment 7•4 years ago
|
||
--- a/widget/nsNativeBasicTheme.h
+++ b/widget/nsNativeBasicTheme.h
@@ -2,23 +2,107 @@
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef nsNativeBasicTheme_h
#define nsNativeBasicTheme_h
+#include "mozilla/StaticPrefs_layout.h"
+#include "mozilla/ClearOnShutdown.h"
+#include "mozilla/dom/HTMLMeterElement.h"
+#include "mozilla/dom/HTMLProgressElement.h"
+#include "nsColorControlFrame.h"
+#include "nsDateTimeControlFrame.h"
+#include "nsDeviceContext.h"
#include "nsITheme.h"
+#include "nsMeterFrame.h"
#include "nsNativeTheme.h"
+#include "nsProgressFrame.h"
+#include "nsRangeFrame.h"
+
+using namespace mozilla;
+using namespace mozilla::gfx;
Hey, we're not supposed to put using
declarations in headers, can you please take care of that in a followup?
Comment 8•4 years ago
|
||
I believe the using
declarations in headers here broke my local linux builds.
Comment 9•4 years ago
|
||
Sorry, should've caught this during review.
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
bugherder |
Assignee | ||
Updated•4 years ago
|
Description
•