Closed Bug 1623637 Opened 5 years ago Closed 5 years ago

Split UrlbarProviderSuggestions out from UnifiedComplete

Tracking

()

Status:

RESOLVED FIXED

Milestone:

Firefox 77

Iteration:

77.1 - Apr 6 - Apr 19

Tracking Flags:

Tracking

Status

firefox77

---

fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Blocks 2 open bugs)

Details

Attachments

(6 files)

Bug 1623637 - Part 1 - Fix race in PlacesSearchAutocompleteProvider. 5 years ago Harry Twyford (deleted), text/x-phabricator-request		Details
Bug 1623637 - Part 2 - Add UrlbarProviderSearchSuggestions.jsm. 5 years ago Harry Twyford (deleted), text/x-phabricator-request		Details
Bug 1623637 - Part 3 - Remove suggestions code from UnifiedComplete and enable UrlbarProviderSearchSuggestions. 5 years ago Harry Twyford (deleted), text/x-phabricator-request		Details
Bug 1623637 - Part 4 - Move addBookmark helper to PlacesTestUtils. 5 years ago Harry Twyford (deleted), text/x-phabricator-request		Details
Bug 1623637 - Part 5 - Port test_search_suggestions.js. 5 years ago Harry Twyford (deleted), text/x-phabricator-request		Details
Bug 1623637 - Part 6 - Port part of search_suggestions_aliases.js. 5 years ago Harry Twyford (deleted), text/x-phabricator-request		Details

Harry Twyford

Assignee

Description

•

5 years ago

We'll start with splitting UrlbarProviderSuggestions out from UnifiedComplete. Marco expects this will be the easiest result type to port. This work will give us a better idea of the difficulties we might face as we port other result types into a UrlbarProvider.

Marco Bonardo [:mak]

Updated

•

5 years ago

Priority: -- → P2

Harry Twyford

Assignee

Comment 1

•

5 years ago

Attached file Bug 1623637 - Part 1 - Fix race in PlacesSearchAutocompleteProvider. (deleted) — Details

Harry Twyford

Assignee

Comment 2

•

5 years ago

Attached file Bug 1623637 - Part 2 - Add UrlbarProviderSearchSuggestions.jsm. (deleted) — Details

Depends on D69696

Harry Twyford

Assignee

Comment 3

•

5 years ago

Attached file Bug 1623637 - Part 3 - Remove suggestions code from UnifiedComplete and enable UrlbarProviderSearchSuggestions. (deleted) — Details

Depends on D69697

Harry Twyford

Assignee

Comment 4

•

5 years ago

Attached file Bug 1623637 - Part 4 - Move addBookmark helper to PlacesTestUtils. (deleted) — Details

Depends on D69698

Harry Twyford

Assignee

Comment 5

•

5 years ago

Attached file Bug 1623637 - Part 5 - Port test_search_suggestions.js. (deleted) — Details

Depends on D69699

Harry Twyford

Assignee

Comment 6

•

5 years ago

Attached file Bug 1623637 - Part 6 - Port part of search_suggestions_aliases.js. (deleted) — Details

Depends on D69700

Harry Twyford

Assignee

Comment 7

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=967747d872a45a8dcf8fbe31cb831277ac58a4d7

Harry Twyford

Assignee

Updated

•

5 years ago

Blocks: 1628015

Harry Twyford

Assignee

Updated

•

5 years ago

Blocks: 1628016

Phabricator Automation

Updated

•

5 years ago

Attachment #9138268 - Attachment description: Bug 1623637 - Part 2 - Add UrlbarProviderSuggestions.jsm. → Bug 1623637 - Part 2 - Add UrlbarProviderSearchSuggestions.jsm.

Phabricator Automation

Updated

•

5 years ago

Attachment #9138269 - Attachment description: Bug 1623637 - Part 3 - Remove suggestions code from UnifiedComplete and enable UrlbarProviderSuggestions. → Bug 1623637 - Part 3 - Remove suggestions code from UnifiedComplete and enable UrlbarProviderSearchSuggestions.

Harry Twyford

Assignee

Updated

•

5 years ago

Blocks: 1628079

Harry Twyford

Assignee

Comment 8

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=783a182651918d52ae1bdc7779a422721b087e22

Harry Twyford

Assignee

Updated

•

5 years ago

Iteration: 76.2 - Mar 23 - Apr 5 → 77.1 - Apr 6 - Apr 19

Harry Twyford

Assignee

Comment 9

•

5 years ago

Try run of the final r+'d patches: ~~https://treeherder.mozilla.org/#/jobs?repo=try&revision=a48d0f5cf8d9903e20361f4055048a7757e13506~~

Update: Treeherder hit an exception. Let's try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6efde71ebd78c123f5ae9a44ba9d228f3f7cbf0

Pulsebot

Comment 10

•

5 years ago

Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aeb4b6a030f7 Part 1 - Fix race in PlacesSearchAutocompleteProvider. r=mak https://hg.mozilla.org/integration/autoland/rev/42402e0a35c5 Part 2 - Add UrlbarProviderSearchSuggestions.jsm. r=mak https://hg.mozilla.org/integration/autoland/rev/27c5961fc195 Part 3 - Remove suggestions code from UnifiedComplete and enable UrlbarProviderSearchSuggestions. r=mak https://hg.mozilla.org/integration/autoland/rev/c479ea11c586 Part 4 - Move addBookmark helper to PlacesTestUtils. r=mak https://hg.mozilla.org/integration/autoland/rev/52ab9d52c4ed Part 5 - Port test_search_suggestions.js. r=mak https://hg.mozilla.org/integration/autoland/rev/5980851731f7 Part 6 - Port part of search_suggestions_aliases.js. r=mak

Cristina Coroiu [:ccoroiu]

Comment 11

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/aeb4b6a030f7
https://hg.mozilla.org/mozilla-central/rev/42402e0a35c5
https://hg.mozilla.org/mozilla-central/rev/27c5961fc195
https://hg.mozilla.org/mozilla-central/rev/c479ea11c586
https://hg.mozilla.org/mozilla-central/rev/52ab9d52c4ed
https://hg.mozilla.org/mozilla-central/rev/5980851731f7

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox77: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 77

Marco Bonardo [:mak]

Updated

•

4 years ago

Regressions: 1648385

You need to log in before you can comment on or make changes to this bug.