Closed Bug 1626458 Opened 5 years ago Closed 5 years ago

Remove pref for CSS Containment (layout.css.contain.enabled)

Categories

(Core :: CSS Parsing and Computation, task, P3)

task

Tracking

()

VERIFIED FIXED
mozilla77
Tracking Status
firefox77 --- verified

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(2 files)

We've been shipping with CSS containment enabled for several releases now (ever since Firefox 69, via bug 1487493 landing on 70 and then being uplifted to 69).

We might as well remove the about:config pref.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED

Oh, hmm -- it looks like we have a reftest that depends on preffing this property off, which means it needs to remain preffable for the time being in order for that reftest to continue functioning properly.
The test is:
https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/layout/reftests/bugs/1466008.html
...and here's the reftest.list line where we pref this property off:
https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/layout/reftests/bugs/reftest.list#2054

For now, I'll just spin off a helper-bug to simply change our tests to assume the pref is default-true everywhere (which in practice it has to be at this point) -- i.e. I'll remove all the test lines that manually set it to true. But I'll keep the pref, and I'll leave that one reftest in place (and leave this bug open to track removing the pref once we've got a better solution for that reftest.)

Assignee: dholbert → nobody
Status: ASSIGNED → NEW
Depends on: 1626459

per bug 1466008 comment 13, we can switch to using backdrop-filter (and its pref, layout.css.backdrop-filter.enabled) in that reftest.

I'll plan to take care of this soon, now that helper bug 1626459 has landed.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED

(Since we've been shipping with it default-enabled for a while now.)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1466008#c9 through #c13 for
notes on the reftest.list change.

This patch's changes were automatically generated by the following command:
./mach devtools-css-db

Depends on D71861

Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7d9b81aa753 part 1: Remove pref for CSS Containment (layout.css.contain.enabled) r=AlaskanEmily https://hg.mozilla.org/integration/autoland/rev/b6daad2bedbd part 2: Regenerate devtools CSS database, now that the 'contain' property isn't pref-controlled. r=AlaskanEmily
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Flags: qe-verify+

Can confirm that the pref layout.css.contain.enabled was successfully removed in 77.0b8 across platforms (Windows 10 64bit, macOS 10.15.5 beta 3 and Ubuntu 18.04 64bit).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: