Closed Bug 1626459 Opened 5 years ago Closed 5 years ago

Remove test annotations that pref on CSS containment (since it's already default-true)

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

I noticed today (when running WPT) that we've got a number of places where we manually pref on css containment for testing purposes. This isn't necessary at this point, since it's default-enabled & that's not going to change since we've been shipping it for multiple releases.

We can't remove the pref entirely yet, because there's a test that depends on preffing it off (temporarily) to test something else (see bug 1626458 comment 1). But we might as well remove all of the boilerplate that sets it to true for specific tests here and there.

i.e. remove annotations that manually enable the property, and remove the
property_database.js check that tests for the property being enabled.

We've been shipping with the property enabled ever since Firefox 69, so we're
realistically not going to default-disable it at this point, which means these
annotations (and the property_database.js check) are just cruft.

(For reference: this about:config pref has been default-enabled since bug 1487493, which made it to release as of Firefox 69, via a beta uplift at the time.)

Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/653c00f85c1e Simplify test annotations/code to assume that CSS Containment is preffed on by default. r=AlaskanEmily
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: