Closed Bug 1627200 Opened 5 years ago Closed 4 years ago

<datalist> in popup.html throws error in one of the autocomplete??.js

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Type:
defect

Tracking

(thunderbird78+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 79.0
Tracking Flags:
Tracking Status
thunderbird78 + fixed

People

(Reporter: buecher, Assigned: darktrojan)

References

Details

Attachments

(2 files)

1627200-datalist-1.diff
(deleted), patch
aleca
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review
1627200-gloda-exceptions-1.diff
(deleted), patch
aleca
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

a mini popup of height 0.5mm is displayed. Debugger indicates error in one of the autocomplete.js files. Example at: https://github.com/opto/TB_MailExt_1 brach select_datalist.

I saw there is a large number of bugs relating to datalist but they are all resolved.

Blocks: webext-tb

This doesn't appear to work anywhere in Thunderbird.

No longer blocks: webext-tb
Status: UNCONFIRMED → NEW
Component: Add-Ons: Extensions API → General
Ever confirmed: true

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Severity: normal → --
Attached patch 1627200-datalist-1.diff (deleted) — — Splinter Review

Aleca, you're most likely to notice if I've broken anything here. The first part of this patch fixes the popup itself. The second part restricts the existing custom CSS to local-abook and remote-abook types – ie. autocomplete results from the address book, I think they're the only things this CSS is for.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9156131 - Flags: review?(alessandro)
Comment on attachment 9156131 [details] [diff] [review] 1627200-datalist-1.diff Review of attachment 9156131 [details] [diff] [review]: ----------------------------------------------------------------- This looks good and it doesn't seem to affect any other autocomplete.
Attachment #9156131 - Flags: review?(alessandro) → review+
Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/292ed2f81859
Fix autocomplete popup of <input> with <datalist>. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 79.0

I forgot that gloda-autocomplete-input.js throws exceptions like mad when using datalist.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch 1627200-gloda-exceptions-1.diff (deleted) — — Splinter Review
Attachment #9156160 - Flags: review?(alessandro)
Comment on attachment 9156160 [details] [diff] [review] 1627200-gloda-exceptions-1.diff Review of attachment 9156160 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, sorry for missing this issue.
Attachment #9156160 - Flags: review?(alessandro) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f82b61ed451a
Mitigate exceptions thrown in gloda-autocomplete-input when using datalist. r=aleca DONTBUILD

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED

I guess this needs uplift?

status-thunderbird78: --- → affected
tracking-thunderbird78: --- → +

Yes but I'm still working in this area, it can wait for the rest of the work. It may even get a test if I get that far!

Comment on attachment 9156131 [details] [diff] [review] 1627200-datalist-1.diff Needs to go with bug 1645945, not risky.
Attachment #9156131 - Flags: approval-comm-beta?
Attachment #9156160 - Flags: approval-comm-beta?
Comment on attachment 9156131 [details] [diff] [review] 1627200-datalist-1.diff Approved for beta
Attachment #9156131 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9156160 [details] [diff] [review] 1627200-gloda-exceptions-1.diff Approved for beta
Attachment #9156160 - Flags: approval-comm-beta? → approval-comm-beta+
Regressions: 1653213
Regressions: 1670457
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: