Closed Bug 1670457 Opened 4 years ago Closed 1 year ago

When editing a newsgroup header, only the account name is displayed in the selection list.

Categories

(Thunderbird :: Message Compose Window, defect)

defect

Tracking

(thunderbird_esr115? affected, thunderbird118? affected)

RESOLVED FIXED
119 Branch
Tracking Status
thunderbird_esr115 ? affected
thunderbird118 ? affected

People

(Reporter: infofrommozilla, Assigned: welpy-cw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files)

Attached image editNGHeader_TB78.png (deleted) —

When I write an article to a newsgroup and edit the Newsgroup or Followup-To header, an selection list opens with suggested newsgroup names. The list should have the format: "<group-name> - <account>"
In TB78+ only the <account> is shown.

Attached image TB68 shows how it should look like. (deleted) —

TB68 shows how it should look like.

Blocks: tb78found

Probably a regression of bug 440377 (tb-pills) ?

Keywords: regression

Indeed this wasn't regressed by the pills as that implementation didn't affect the autocomplete.

This is the regression window.

Assignee: nobody → h.w.forms
Status: NEW → ASSIGNED

This quick and dirty fix mitigates the regression. Maybe it would be more elegant to adapt the changed CSS code.

(In reply to Hartmut Welpmann [:welpy-cw] from comment #7)

This quick and dirty fix mitigates the regression.

-    return "subscribed-news";
+    return "subscribed-news-abook";

Yes that works. But I also think that is misleading.

Attached patch bug1670457.patch (deleted) — Splinter Review

(In reply to Hartmut Welpmann [:welpy-cw] from comment #7)

Maybe it would be more elegant to adapt the changed CSS code.

This one works as well.

But I must confess that I don't really know what I'm doing. A CSS expert should definitely take another look at this.

Target Milestone: --- → 118 Branch
Target Milestone: 118 Branch → 119 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/aab067903744
Show group name in newsgroup autocomplete. r=mkmelin,aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Comment on attachment 9350115 [details]
Bug 1670457 - Show group name in newsgroup autocomplete. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1627200
User impact if declined: autocomplete of newsgroup header input not showing essential information
Risk to taking this patch (and alternatives if risky): low

Attachment #9350115 - Flags: approval-comm-esr115?
Attachment #9350115 - Flags: approval-comm-beta?

Comment on attachment 9350115 [details]
Bug 1670457 - Show group name in newsgroup autocomplete. r=mkmelin

[Triage Comment]
Approved for beta (not yet on c-c, but has limited scope impact)

Attachment #9350115 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: