Unblock NVIDIA driver 26.21.14.4575 for hardware acceleration
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox75 | --- | unaffected |
firefox76 | --- | fixed |
firefox77 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
As it turns out, the NVIDIA driver 26.21.14.4575 was not the problem, and it appears to be related to laptops and dual GPUs. We should unblock the driver for hardware acceleration so these users can continue to get optimal performance.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
This reverts the patch landed in bug 1625857. As it turns out, the
driver version is less significant than the fact that it is a laptop
with dual GPUs. We should continue to give users with this driver
hardware acceleration for optimal performance.
Comment 4•5 years ago
|
||
bugherder |
Comment 6•5 years ago
|
||
I'm on 445.75 and the Firefox Beta and am still seeing this behaviour. How often does the blacklist update, or do I need to wait for a new build?
Decision Log
HW_COMPOSITING
force_enabled by user: Force-enabled by pref
D3D11_COMPOSITING
Blocklisted; failure code BLOCKLIST_NVIDIA driver != 26.21.14.4575
DIRECT2D
unavailable by default: Direct2D requires Direct3D 11 compositing
D3D11_HW_ANGLE
unavailable by default: D3D11 compositing is disabled
disabled by env: D3D11 compositing is disabled
GPU_PROCESS
Blocklisted; failure code BLOCKLIST_NVIDIA driver != 26.21.14.4575
WEBRENDER
opt-in by default: WebRender is an opt-in feature
unavailable-no-angle by runtime: ANGLE is disabled
WEBRENDER_QUALIFIED
blacklisted by env: No qualified hardware
WEBRENDER_COMPOSITOR
unavailable by env: No DirectComposition usage
WEBGPU
disabled by default: Disabled by default
Comment 8•5 years ago
|
||
EDIT: Ignore me. I misread the blocklist error messages (they should probably show 'version == x' to make it clear what the failure condition is)
Comment 9•5 years ago
|
||
(In reply to Jonathan Guerin from comment #6)
I'm on 445.75 and the Firefox Beta and am still seeing this behaviour. How often does the blacklist update, or do I need to wait for a new build?
Decision Log HW_COMPOSITING force_enabled by user: Force-enabled by pref D3D11_COMPOSITING Blocklisted; failure code BLOCKLIST_NVIDIA driver != 26.21.14.4575 DIRECT2D unavailable by default: Direct2D requires Direct3D 11 compositing D3D11_HW_ANGLE unavailable by default: D3D11 compositing is disabled disabled by env: D3D11 compositing is disabled GPU_PROCESS Blocklisted; failure code BLOCKLIST_NVIDIA driver != 26.21.14.4575 WEBRENDER opt-in by default: WebRender is an opt-in feature unavailable-no-angle by runtime: ANGLE is disabled WEBRENDER_QUALIFIED blacklisted by env: No qualified hardware WEBRENDER_COMPOSITOR unavailable by env: No DirectComposition usage WEBGPU disabled by default: Disabled by default
This still needs to be uplifted to beta.
Comment 10•5 years ago
|
||
The patch landed in nightly and beta is affected.
:aosmond, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 11•5 years ago
|
||
Comment on attachment 9139565 [details]
Bug 1628817 - Revert blocking of all features with NVIDIA driver version 26.21.14.4575.
Beta/Release Uplift Approval Request
- User impact if declined: Users will not get WebRender when they should have.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): We were wrong to block the driver in the first place, it is working just fine. The problem turned out to be more related to specific hardware combinations. Very low risk we were shipping on this until very recently.
- String changes made/needed:
Comment 12•5 years ago
|
||
Comment on attachment 9139565 [details]
Bug 1628817 - Revert blocking of all features with NVIDIA driver version 26.21.14.4575.
Re-enables WebRender for users on newer nVidia drivers. Approved for 76.0b5.
Comment 13•5 years ago
|
||
bugherder uplift |
Description
•