1628976 - Firefox fails to build with KeyError: ('_projects_mozilla_unified_servo_components_style_properties_longhands_background_mako_rs', 'helpers')

Reporter

Description

•

5 years ago

m-c fails to build with:

▶ ./mach build
 0:00.36 Clobber not needed.
 0:00.36 Adding make options from /projects/mozilla-unified/.mozconfig
    AUTOCLOBBER=1
    MOZ_MAKE_FLAGS=-j16
    MOZ_OBJDIR=/projects/mozilla-unified/obj-x86_64-pc-linux-gnu-dbg
    OBJDIR=/projects/mozilla-unified/obj-x86_64-pc-linux-gnu-dbg
    FOUND_MOZCONFIG=/projects/mozilla-unified/.mozconfig
    export FOUND_MOZCONFIG
 0:00.37 /usr/bin/make -f client.mk MOZ_PARALLEL_BUILD=16 -s
 0:00.48 Elapsed: 0.00s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.49 Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.50 Elapsed: 0.00s; From dist/xpi-stage: Kept 88 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.56 Elapsed: 0.08s; From _tests: Kept 1427 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.56 Elapsed: 0.09s; From dist/bin: Kept 2634 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.63 Elapsed: 0.15s; From dist/include: Kept 6141 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:00.65 ./buildid.h.stub
 0:00.72 ./source-repo.h.stub
 0:01.05 layout/style/ServoCSSPropList.py.stub
 0:01.05 build/application.ini.stub
 0:01.07 xpcom/tests/gtest/dafsa_test_1.inc.stub
 0:01.07 xpcom/idl-parser/xpidl/xpidl.stub.stub
 0:01.07 js/src/gc/StatsPhasesGenerated.h.stub
 0:01.07 js/src/frontend/ReservedWordsGenerated.h.stub
 0:01.07 js/src/jit/MOpcodes.h.stub
 0:01.16 js/src/jit/LOpcodes.h.stub
 0:01.16 build/application.ini.h.stub
 0:01.18 js/src/gc/StatsPhasesGenerated.inc.stub
 0:01.19 WARNING: mkdir -dot- requested by /usr/bin/make -C /projects/mozilla-unified/obj-x86_64-pc-linux-gnu-dbg/config/makefiles/xpidl xpidl
 0:01.20 config/makefiles/xpidl/Bits.xpt
 0:01.20 config/makefiles/xpidl/accessibility.xpt
 0:01.20 config/makefiles/xpidl/alerts.xpt
 0:01.20 config/makefiles/xpidl/appshell.xpt
 0:01.20 config/makefiles/xpidl/appstartup.xpt
 0:01.20 config/makefiles/xpidl/autocomplete.xpt
 0:01.20 config/makefiles/xpidl/backgroundhangmonitor.xpt
 0:01.20 config/makefiles/xpidl/browser-element.xpt
 0:01.20 config/makefiles/xpidl/browser-newtab.xpt
 0:01.20 config/makefiles/xpidl/browsercompsbase.xpt
 0:01.20 config/makefiles/xpidl/caps.xpt
 0:01.20 config/makefiles/xpidl/captivedetect.xpt
 0:01.21 config/makefiles/xpidl/chrome.xpt
 0:01.33 config/makefiles/xpidl/commandhandler.xpt
 0:01.33 config/makefiles/xpidl/commandlines.xpt
 0:01.37 config/makefiles/xpidl/composer.xpt
 0:01.45 config/makefiles/xpidl/content_events.xpt
 0:01.45 config/makefiles/xpidl/content_geckomediaplugins.xpt
 0:01.45 config/makefiles/xpidl/content_html.xpt
 0:01.45 config/makefiles/xpidl/content_webrtc.xpt
 0:01.47 Traceback (most recent call last):
 0:01.47   File "_projects_mozilla_unified_servo_components_style_properties_longhands_background_mako_rs", line 16, in _mako_get_namespace
 0:01.47 config/makefiles/xpidl/docshell.xpt
 0:01.47 KeyError: ('_projects_mozilla_unified_servo_components_style_properties_longhands_background_mako_rs', 'helpers')
 0:01.47 During handling of the above exception, another exception occurred:
 0:01.47 Traceback (most recent call last):
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/lookup.py", line 237, in get_template
 0:01.47 config/makefiles/xpidl/dom.xpt
 0:01.47 KeyError: '/helpers.mako.rs'
 0:01.47 During handling of the above exception, another exception occurred:
 0:01.47 Traceback (most recent call last):
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/build.py", line 149, in render
 0:01.47     return template.render(**context)
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/template.py", line 443, in render
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/runtime.py", line 806, in _render
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/runtime.py", line 839, in _render_context
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/runtime.py", line 865, in _exec_template
 0:01.47   File "_projects_mozilla_unified_servo_components_style_properties_longhands_background_mako_rs", line 29, in render_body
 0:01.47   File "_projects_mozilla_unified_servo_components_style_properties_longhands_background_mako_rs", line 18, in _mako_get_namespace
 0:01.47   File "_projects_mozilla_unified_servo_components_style_properties_longhands_background_mako_rs", line 22, in _mako_generate_namespaces
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/runtime.py", line 549, in __init__
 0:01.47   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/runtime.py", line 773, in _lookup_template
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/lookup.py", line 245, in get_template
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/lookup.py", line 306, in _load
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/template.py", line 321, in __init__
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/template.py", line 396, in _compile_from_file
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/template.py", line 653, in _compile_text
 0:01.48   File "_helpers_mako_rs", line 61
 0:01.48     def render_predefined_type(context,name,type,initial_value,parse_method=,needs_context=,vector=,computed_type=,initial_specified_value=,allow_quirks=,allow_empty=,**kwargs):
 0:01.48                                                                             ^
 0:01.48 SyntaxError: invalid syntax
 0:01.48 During handling of the above exception, another exception occurred:
 0:01.48 Traceback (most recent call last):
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/build.py", line 168, in <module>
 0:01.48     main()
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/build.py", line 71, in main
 0:01.48     files[kind][struct] = render(
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/build.py", line 153, in render
 0:01.48     abort(exceptions.text_error_template().render())
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/exceptions.py", line 221, in text_error_template
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/template.py", line 303, in __init__
 0:01.48   File "/projects/mozilla-unified/servo/components/style/properties/Mako-0.9.1.zip/mako/template.py", line 653, in _compile_text
 0:01.48   File "memory:0x7fc157050c10", line 19
 0:01.48     def render_body(context,error=,traceback=,**pageargs):
 0:01.48                                   ^
 0:01.48 SyntaxError: invalid syntax
 0:01.50 config/makefiles/xpidl/dom_audiochannel.xpt
 0:01.50 Traceback (most recent call last):
 0:01.50   File "/usr/lib64/python3.8/runpy.py", line 193, in _run_module_as_main
 0:01.50     return _run_code(code, main_globals, None,
 0:01.50   File "/usr/lib64/python3.8/runpy.py", line 86, in _run_code
 0:01.50     exec(code, run_globals)
 0:01.50   File "/projects/mozilla-unified/python/mozbuild/mozbuild/action/file_generate.py", line 124, in <module>
 0:01.50     sys.exit(main(sys.argv[1:]))
 0:01.50   File "/projects/mozilla-unified/python/mozbuild/mozbuild/action/file_generate.py", line 72, in main
 0:01.50     ret = module.__dict__[method](output, *args.additional_arguments, **kwargs)
 0:01.51   File "/projects/mozilla-unified/layout/style/GenerateServoCSSPropList.py", line 19, in generate_data
 0:01.51     output.write(subprocess.check_output([
 0:01.51   File "/usr/lib64/python3.8/subprocess.py", line 411, in check_output
 0:01.51     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
 0:01.51   File "/usr/lib64/python3.8/subprocess.py", line 512, in run
 0:01.51     raise CalledProcessError(retcode, process.args,
 0:01.51 subprocess.CalledProcessError: Command '['/projects/mozilla-unified/obj-x86_64-pc-linux-gnu-dbg/_virtualenvs/init_py3/bin/python', '/projects/mozilla-unified/servo/components/style/properties/build.py', 'gecko', 'geckolib', '/projects/mozilla-unified/layout/style/ServoCSSPropList.mako.py']' returned non-zero exit status 1.
 0:01.51 config/makefiles/xpidl/dom_base.xpt
 0:01.53 make[4]: *** [backend.mk:33: .deps/ServoCSSPropList.py.stub] Error 1
 0:01.53 make[3]: *** [/projects/mozilla-unified/config/recurse.mk:101: layout/style/export] Error 2
 0:01.53 make[3]: *** Waiting for unfinished jobs....
 0:01.54 config/makefiles/xpidl/dom_bindings.xpt
 0:01.58 config/makefiles/xpidl/dom_bindings_test.xpt
 0:01.60 config/makefiles/xpidl/dom_events.xpt
 0:01.62 config/makefiles/xpidl/dom_geolocation.xpt
 0:01.68 config/makefiles/xpidl/dom_html.xpt
 0:01.70 config/makefiles/xpidl/dom_indexeddb.xpt
 0:01.72 config/makefiles/xpidl/dom_localstorage.xpt
 0:01.72 config/makefiles/xpidl/dom_media.xpt
 0:01.73 config/makefiles/xpidl/dom_network.xpt
 0:01.76 config/makefiles/xpidl/dom_notification.xpt
 0:01.78 config/makefiles/xpidl/dom_payments.xpt
 0:01.82 config/makefiles/xpidl/dom_power.xpt
 0:01.82 config/makefiles/xpidl/dom_presentation.xpt
 0:01.85 config/makefiles/xpidl/dom_push.xpt
 0:01.85 config/makefiles/xpidl/dom_quota.xpt
 0:01.86 config/makefiles/xpidl/dom_security.xpt
 0:01.93 config/makefiles/xpidl/dom_sidebar.xpt
 0:01.94 config/makefiles/xpidl/dom_simpledb.xpt
 0:01.98 config/makefiles/xpidl/dom_storage.xpt
 0:01.99 config/makefiles/xpidl/dom_system.xpt
 0:02.03 config/makefiles/xpidl/dom_webauthn.xpt
 0:02.03 config/makefiles/xpidl/dom_webspeechrecognition.xpt
 0:02.04 config/makefiles/xpidl/dom_webspeechsynth.xpt
 0:02.08 config/makefiles/xpidl/dom_workers.xpt
 0:02.15 config/makefiles/xpidl/dom_xslt.xpt
 0:02.15 config/makefiles/xpidl/dom_xul.xpt
 0:02.18 config/makefiles/xpidl/downloads.xpt
 0:02.23 config/makefiles/xpidl/editor.xpt
 0:02.23 config/makefiles/xpidl/enterprisepolicies.xpt
 0:02.26 config/makefiles/xpidl/extensions.xpt
 0:02.28 config/makefiles/xpidl/exthandler.xpt
 0:02.28 config/makefiles/xpidl/fastfind.xpt
 0:02.31 config/makefiles/xpidl/gfx.xpt
 0:02.33 config/makefiles/xpidl/html5.xpt
 0:02.35 config/makefiles/xpidl/htmlparser.xpt
 0:02.38 config/makefiles/xpidl/imglib2.xpt
 0:02.39 config/makefiles/xpidl/inspector.xpt
 0:02.39 config/makefiles/xpidl/intl.xpt
 0:02.43 config/makefiles/xpidl/jar.xpt
 0:02.44 config/makefiles/xpidl/jsdebugger.xpt
 0:02.49 config/makefiles/xpidl/jsinspector.xpt
 0:02.49 config/makefiles/xpidl/kvstore.xpt
 0:02.54 config/makefiles/xpidl/layout_base.xpt
 0:02.54 config/makefiles/xpidl/layout_debug.xpt
 0:02.58 config/makefiles/xpidl/layout_printing.xpt
 0:02.60 config/makefiles/xpidl/layout_xul_tree.xpt
 0:02.60 config/makefiles/xpidl/locale.xpt
 0:02.63 config/makefiles/xpidl/loginmgr.xpt
 0:02.67 config/makefiles/xpidl/migration.xpt
 0:02.73 config/makefiles/xpidl/mimetype.xpt
 0:02.73 config/makefiles/xpidl/mozfind.xpt
 0:02.74 config/makefiles/xpidl/mozintl.xpt
 0:02.74 config/makefiles/xpidl/necko.xpt
 0:02.76 config/makefiles/xpidl/necko_about.xpt
 0:02.77 config/makefiles/xpidl/necko_cache.xpt
 0:02.80 config/makefiles/xpidl/necko_cache2.xpt
 0:02.84 config/makefiles/xpidl/necko_cookie.xpt
 0:02.85 config/makefiles/xpidl/necko_dns.xpt
 0:02.85 config/makefiles/xpidl/necko_file.xpt
 0:02.89 config/makefiles/xpidl/necko_ftp.xpt
 0:02.94 config/makefiles/xpidl/necko_http.xpt
 0:02.95 config/makefiles/xpidl/necko_mdns.xpt
 0:03.01 config/makefiles/xpidl/necko_res.xpt
 0:03.01 config/makefiles/xpidl/necko_socket.xpt
 0:03.03 config/makefiles/xpidl/necko_strconv.xpt
 0:03.03 config/makefiles/xpidl/necko_viewsource.xpt
 0:03.03 config/makefiles/xpidl/necko_websocket.xpt
 0:03.04 config/makefiles/xpidl/necko_wifi.xpt
 0:03.05 config/makefiles/xpidl/parentalcontrols.xpt
 0:03.08 config/makefiles/xpidl/peerconnection.xpt
 0:03.16 config/makefiles/xpidl/pipnss.xpt
 0:03.21 config/makefiles/xpidl/pippki.xpt
 0:03.23 config/makefiles/xpidl/places.xpt
 0:03.23 config/makefiles/xpidl/plugin.xpt
 0:03.25 config/makefiles/xpidl/pref.xpt
 0:03.27 config/makefiles/xpidl/prefetch.xpt
 0:03.27 config/makefiles/xpidl/profiler.xpt
 0:03.27 config/makefiles/xpidl/remote.xpt
 0:03.30 config/makefiles/xpidl/reputationservice.xpt
 0:03.33 config/makefiles/xpidl/sandbox.xpt
 0:03.37 config/makefiles/xpidl/satchel.xpt
 0:03.39 config/makefiles/xpidl/services.xpt
 0:03.41 config/makefiles/xpidl/services-crypto-component.xpt
 0:03.46 config/makefiles/xpidl/sessionStore_funcs.xpt
 0:03.49 config/makefiles/xpidl/shellservice.xpt
 0:03.49 config/makefiles/xpidl/shistory.xpt
 0:03.55 config/makefiles/xpidl/spellchecker.xpt
 0:03.56 config/makefiles/xpidl/startupcache.xpt
 0:03.58 config/makefiles/xpidl/storage.xpt
 0:03.63 config/makefiles/xpidl/telemetry.xpt
 0:03.65 config/makefiles/xpidl/test_necko.xpt
 0:03.66 config/makefiles/xpidl/thumbnails.xpt
 0:03.68 config/makefiles/xpidl/toolkit_antitracking.xpt
 0:03.69 config/makefiles/xpidl/toolkit_asyncshutdown.xpt
 0:03.70 config/makefiles/xpidl/toolkit_cleardata.xpt
 0:03.70 config/makefiles/xpidl/toolkit_crashservice.xpt
 0:03.70 config/makefiles/xpidl/toolkit_filewatcher.xpt
 0:03.74 config/makefiles/xpidl/toolkit_finalizationwitness.xpt
 0:03.83 config/makefiles/xpidl/toolkit_osfile.xpt
 0:03.85 config/makefiles/xpidl/toolkit_search.xpt
 0:03.91 config/makefiles/xpidl/toolkit_securityreporter.xpt
 0:03.96 config/makefiles/xpidl/toolkit_shell.xpt
 0:03.97 config/makefiles/xpidl/toolkit_xulstore.xpt
 0:03.98 config/makefiles/xpidl/toolkitprofile.xpt
 0:03.98 config/makefiles/xpidl/txmgr.xpt
 0:03.98 config/makefiles/xpidl/txtsvc.xpt
 0:03.98 config/makefiles/xpidl/uconv.xpt
 0:04.03 config/makefiles/xpidl/update.xpt
 0:04.03 config/makefiles/xpidl/uriloader.xpt
 0:04.05 config/makefiles/xpidl/url-classifier.xpt
 0:04.06 config/makefiles/xpidl/urlformatter.xpt
 0:04.06 config/makefiles/xpidl/webBrowser_core.xpt
 0:04.09 config/makefiles/xpidl/webbrowserpersist.xpt
 0:04.17 config/makefiles/xpidl/webextensions.xpt
 0:04.19 config/makefiles/xpidl/webvtt.xpt
 0:04.24 config/makefiles/xpidl/widget.xpt
 0:04.25 config/makefiles/xpidl/windowcreator.xpt
 0:04.25 config/makefiles/xpidl/windowwatcher.xpt
 0:04.25 config/makefiles/xpidl/xpcom_base.xpt
 0:04.28 config/makefiles/xpidl/xpcom_components.xpt
 0:04.28 config/makefiles/xpidl/xpcom_ds.xpt
 0:04.30 config/makefiles/xpidl/xpcom_io.xpt
 0:04.34 config/makefiles/xpidl/xpcom_system.xpt
 0:04.36 config/makefiles/xpidl/xpcom_threads.xpt
 0:04.37 config/makefiles/xpidl/xpcomtest.xpt
 0:04.41 config/makefiles/xpidl/xpconnect.xpt
 0:04.50 config/makefiles/xpidl/xpctest.xpt
 0:04.50 config/makefiles/xpidl/xul.xpt
 0:04.51 config/makefiles/xpidl/xulapp.xpt
 0:04.53 config/makefiles/xpidl/zipwriter.xpt
 0:05.38 config/makefiles/xpidl/xptdata.cpp
 0:06.16 make[2]: *** [/projects/mozilla-unified/config/recurse.mk:34: export] Error 2
 0:06.16 make[1]: *** [/projects/mozilla-unified/config/rules.mk:394: default] Error 2
 0:06.16 make: *** [client.mk:125: build] Error 2
 0:06.18 335 compiler warnings present.

System:
Arch Linux
m-c, debug build

I suspect a regression from bug 1621447

Flags: needinfo?(emilio)

Mike Hommey [:glandium]

Updated

•

5 years ago

Regressed by: 1621447

BMO Automation

Updated

•

5 years ago

Has Regression Range: --- → yes

Mike Hommey [:glandium]

Comment 1

•

5 years ago

Mako needs an update. 0.9.1 is not compatible with python 3.8.

Emilio Cobos Álvarez (:emilio)

Assignee

Updated

•

5 years ago

Assignee: nobody → emilio

Flags: needinfo?(emilio)

Emilio Cobos Álvarez (:emilio)

Assignee

Comment 2

•

5 years ago

Attached file Bug 1628976 - Update mako in the style system. r=SimonSapin (deleted) — Details

This uses Mako-1.1.2 wheel format, rather than zip, and works with py3 and py2.

It'd be great to make mako more like other third party python dependencies but
this allows me to build central again.

Emilio Cobos Álvarez (:emilio)

Assignee

Comment 3

•

5 years ago

This breaks local builds so I'm going to ask for forgiveness and land it. Mike, can you stamp it when you're up again?

Flags: needinfo?(mh+mozilla)

Pulsebot

Comment 4

•

5 years ago

Pushed by shindli@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/280c84604ac0 Update mako in the style system. r=SimonSapin

Emilio Cobos Álvarez (:emilio)

Assignee

Comment 5

•

5 years ago

Simon reviewed and landed directly to central with the approval from Aryx. Though if we had a better setup for this it'd be great.

Status: NEW → RESOLVED

Closed: 5 years ago

Flags: needinfo?(mh+mozilla)

Resolution: --- → FIXED

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

5 years ago

status-firefox77: --- → fixed

Target Milestone: --- → mozilla77

BugBot [:suhaib / :marco/ :calixte]

Updated

•

5 years ago

Keywords: regression

Zibi Braniecki [:zbraniecki][:gandalf]

Reporter

Comment 6

•

5 years ago

WFM!

Status: RESOLVED → VERIFIED

Ryan VanderMeulen [:RyanVM]

Updated

•

5 years ago

status-firefox74: --- → unaffected

status-firefox75: --- → unaffected

status-firefox76: --- → unaffected

status-firefox-esr68: --- → unaffected

Phabricator Automation

Updated

•

5 years ago

Attachment #9139724 - Attachment description: Bug 1628976 - Update mako in the style system. r=#style → Bug 1628976 - Update mako in the style system. r=SimonSapin

Bugzilla

Quick Search

Firefox fails to build with KeyError: ('_projects_mozilla_unified_servo_components_style_properties_longhands_background_mako_rs', 'helpers')

Categories

(Firefox Build System :: General, defect)

Tracking

(firefox-esr68 unaffected, firefox74 unaffected, firefox75 unaffected, firefox76 unaffected, firefox77 fixed)

People

(Reporter: zbraniecki, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Updated

Updated

Comment 1

Updated

Comment 2

Comment 3

Comment 4

Comment 5

Updated

Updated

Comment 6

Updated

Updated

Attachment

General

Description

File Name

Content Type