Closed Bug 1629079 Opened 5 years ago Closed 5 years ago

Consolidate throbber UI

Categories

(SeaMonkey :: UI Design, enhancement)

Product:
SeaMonkey
Component:
UI Design
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.75
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.3)

Attachments

(3 files, 2 obsolete files)

Merge throbber code with only one url
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
1629079-mergeThrobber-v1_1-cc.patch
(deleted), patch
frg
: review+
Details | Diff | Splinter Review
1629079-unthrobber.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review

This has been bothering me for a while and, now that Bug 1628928 has tidied up some code, it is possible to remove some code / string duplication for the various throbbers.

Attached patch Merge throbber code (obsolete) (deleted) — — Splinter Review

This patch:

  • Moves throbber code / strings into utilityOverlay
  • Removes some duplication of overlay loading from mailnews
Attachment #9139786 - Flags: review?(frgrahl)
Attachment #9139786 - Flags: approval-comm-release?
Attachment #9139786 - Flags: approval-comm-esr60?
Attached patch Merge throbber code without extras (obsolete) (deleted) — — Splinter Review

Removed changes from unpublished patch. Patch order I have is:
606683-customiseEditToolbar.patch
1628372-hide-sync-button.patch
1628412-fix-find.patch
1628485-fixEditorClose.patch
1628873-mergeEditorSmiley.patch
1628890-port714390-v1_1.patch
1628928-editorThrobber.patch
1629079-mergeThrobber.patch

Attachment #9139786 - Attachment is obsolete: true
Attachment #9139786 - Flags: review?(frgrahl)
Attachment #9139786 - Flags: approval-comm-release?
Attachment #9139786 - Flags: approval-comm-esr60?
Attachment #9139937 - Flags: review?(frgrahl)
Attachment #9139937 - Flags: approval-comm-release?
Attachment #9139937 - Flags: approval-comm-esr60?

As discussed on irc, we use the same throbber URL everywhere so we might as well just use a single pref (browser.throbber.url) for them all. This makes it even simpler and more code clean-up.

Attachment #9139937 - Attachment is obsolete: true
Attachment #9139937 - Flags: review?(frgrahl)
Attachment #9139937 - Flags: approval-comm-release?
Attachment #9139937 - Flags: approval-comm-esr60?
Attachment #9146964 - Flags: review?(frgrahl)
Attachment #9146964 - Flags: approval-comm-release?
Attachment #9146964 - Flags: approval-comm-esr60?
Comment on attachment 9146964 [details] [diff] [review] Merge throbber code with only one url LGTM
Attachment #9146964 - Flags: review?(frgrahl)
Attachment #9146964 - Flags: review+
Attachment #9146964 - Flags: approval-comm-release?
Attachment #9146964 - Flags: approval-comm-release+
Attachment #9146964 - Flags: approval-comm-esr60?
Attachment #9146964 - Flags: approval-comm-esr60+

comm-central version

Attachment #9147019 - Flags: review+
Attached patch 1629079-unthrobber.patch (deleted) — — Splinter Review

I believe the preference editor.throbber.url is dead in Thunderbird since the editor code was forked.

Attachment #9147020 - Flags: review?(mkmelin+mozilla)

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/216dd6f69088
Consolidate throbber UI. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → affected
tracking-seamonkey2.53: --- → ?
tracking-seamonkey2.57esr: --- → ?
Target Milestone: --- → seamonkey 2.75
Comment on attachment 9147020 [details] [diff] [review] 1629079-unthrobber.patch Review of attachment 9147020 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! r=mkmelin
Attachment #9147020 - Flags: review?(mkmelin+mozilla) → review+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/93508184bcac Remove obsolete editor.throbber.url pref. r=mkmelin DONTBUILD
Whiteboard: SM2.53.3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: