OpenPGP public key email attachments should use a reduced key, that excludes signatures from others
Categories
(MailNews Core :: Security: OpenPGP, enhancement)
Tracking
(thunderbird102 fixed)
Tracking | Status | |
---|---|---|
thunderbird102 | --- | fixed |
People
(Reporter: KaiE, Assigned: KaiE)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
patch
|
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
A public key can be quite large, if it contains many signatures made by other people (key certifications).
When automatically appending the user's own public key (because we're sending a signed message), we should probably send the minimal version. This requires stripping off signatures with RNP, which depends on upstream https://github.com/rnpgp/rnp/issues/1006
We need to figure out a way for the user to optionally send the full public key.
Assignee | ||
Comment 1•5 years ago
|
||
See also bug 1628097 comment 14
Assignee | ||
Updated•4 years ago
|
Option could be also not to send any key as per bug 1645514
Comment 3•4 years ago
|
||
What about keyservers? My keys are there and a pointer would do.
Comment 4•4 years ago
|
||
Just because you are technical enough to get them uploaded to a keyserver that doesn't mean the average user would have any clue.
Comment 5•4 years ago
|
||
True. But tb could be clever enough to find it there.
Comment 6•4 years ago
|
||
It can already find keys from a keyserver. But we don't upload keys - which is its own can of worms.
I understand that sending minimum keys is now possible since TB 91 and bug#1713664.
Comment 8•3 years ago
|
||
Maybe off-topic, but closely related: In case I use S/MIME for signing instead, what about attaching the used S/MIME certificate similarly? I do not see anything thelike in the menus.
Comment 9•3 years ago
|
||
When you sign with S/MIME the recipient automatically get your certificate at the same time.
Assignee | ||
Comment 10•2 years ago
|
||
I think that by default we should minimize.
We recently added code to minimize in a different scenario:
https://hg.mozilla.org/comm-central/rev/58bcd5abe85a22c9d73f2abbacee8c3e89b02f23
It should be easy to also fix this bug using that new code.
Assignee | ||
Comment 11•2 years ago
|
||
Suggestion as an intermediary solution, without introducing new UI.
For the automatic key attachment, we always use the reduced key (keep user IDs, keep all self-signatures, but strip all foreign signatures).
For all existing mechanisms used to explicitly copy/export/send a key, we continue to use the full key.
Assignee | ||
Comment 12•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 13•2 years ago
|
||
Comment 14•2 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/37b5215866bc
Send reduced size OpenPGP when automatically attaching to emails. r=mkmelin
Assignee | ||
Comment 15•2 years ago
|
||
Comment on attachment 9280475 [details] [diff] [review]
1629309-esr102.patch
[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: unnecessarily big email attachments with signed/encrypted email
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low
Comment hidden (obsolete) |
Updated•2 years ago
|
Comment 17•2 years ago
|
||
Comment on attachment 9280475 [details] [diff] [review]
1629309-esr102.patch
[Triage Comment]
Approved for beta (102)
Comment 18•2 years ago
|
||
bugherder uplift |
Thunderbird 102.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/da7930dd294f
Description
•