Closed Bug 1777251 Opened 2 years ago Closed 2 years ago

OpenPGP external GnuPG: Failure to attach public key, if it's configured with the ID of a subkey

Categories

(MailNews Core :: Security: OpenPGP, defect, P1)

Product:
MailNews Core
Component:
Security: OpenPGP
Version:
Thunderbird 102
Type:
defect

Tracking

(thunderbird_esr102+ fixed, thunderbird103 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 + fixed
thunderbird103 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [TM:102.0.1optimistic])

Attachments

(2 files)

Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig
(deleted), text/x-phabricator-request
wsmwk
: approval-comm-beta+
Details
1777251_esr102.patch
(deleted), patch
KaiE
: review+
rjl
: approval-comm-esr102+
Details | Diff | Splinter Review

When using the external GnuPG mechanism, the user may specify the ID of a subkey for various reasons.

The recently introduced functionality from bug 1629309 fails if a subkey ID is given.

We must automatically use the related primary key instead.

Severity: -- → S3
tracking-thunderbird_esr102: --- → ?
Priority: -- → P1

For the time being, to work around this bug, you may manually disable attaching your public key (attachment menu) while composing a signed/encrypted message - and optionally - manually attach a file with your public key.

Summary: Failure to attach OpenPGP public key, if it's configured as external key with the ID of a subkey → OpenPGP external GnuPG: Failure to attach public key, if it's configured with the ID of a subkey
tracking-thunderbird_esr102: ? → +
Version: unspecified → Thunderbird 102
Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4f8ca2329ab3
Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

Status: NEW → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch

Comment on attachment 9283409 [details]
Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): 1629309
User impact if declined: failure to send email for affected users
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Attachment #9283409 - Flags: approval-comm-esr102?

Comment on attachment 9283409 [details]
Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

[Approval Request Comment]
Needs to be on beta before going to 102.

Attachment #9283409 - Flags: approval-comm-beta?

Comment on attachment 9283409 [details]
Bug 1777251 - Always use primary key when exporting a reduced public key. r=PatrickBrunschwig

[Triage Comment]
Approved for beta

Attachment #9283409 - Flags: approval-comm-beta? → approval-comm-beta+

optimistically approving for TB102.0.1 - assuming it will pass beta over the next several days

Whiteboard: [TM:102.0.1optimistic]

This caused an ESLint failure on comm-esr102 that was not seen on beta:
https://treeherder.mozilla.org/logviewer?job_id=383143679&repo=comm-esr102

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mail/extensions/openpgp/content/modules/RNP.jsm:2423:27 | 'lazy' is not defined. (no-undef)

Flags: needinfo?(kaie)
Attached patch 1777251_esr102.patch (deleted) — — Splinter Review
Attachment #9283835 - Flags: review?(kaie)
Flags: needinfo?(kaie)
Attachment #9283409 - Flags: approval-comm-esr102?
Attachment #9283835 - Flags: review?(kaie) → review+

Comment on attachment 9283835 [details] [diff] [review]
1777251_esr102.patch

[Triage Comment]
Approving comm-esr102 version of previously approved patch.

Attachment #9283835 - Flags: approval-comm-esr102+
Blocks: tb102found
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: