Closed
Bug 1630891
Opened 5 years ago
Closed 5 years ago
Add null check for addon's internal Name
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.2)
Attachments
(1 file)
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
With the change from checking what a locale addon's internalName was to checking what an its internalName started with, it did not take account of those locale addons that did not have an interalName set.
[Approval Request Comment]
Regression caused by (bug #): 1512882
User impact if declined: if a langpack is installed, can potentially cause problems with other addons
Testing completed (on m-c, etc.): 2.53.3
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #9141201 -
Flags: review?(frgrahl)
Attachment #9141201 -
Flags: approval-comm-release?
Attachment #9141201 -
Flags: approval-comm-esr60?
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9141201 [details] [diff] [review]
null check
LGTM r/a+ for our 2.53 and 2.57 release branches.
Attachment #9141201 -
Flags: review?(frgrahl)
Attachment #9141201 -
Flags: review+
Attachment #9141201 -
Flags: approval-comm-release?
Attachment #9141201 -
Flags: approval-comm-release+
Attachment #9141201 -
Flags: approval-comm-esr60?
Attachment #9141201 -
Flags: approval-comm-esr60+
In 2.53.2 final:
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/f0035e5b8ebfd7d0f4988043efddd2713cd3bf4e
Also in 2.57 patch queue.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-seamonkey2.53:
--- → fixed
status-seamonkey2.57esr:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•