This is a tracking bug for Build and Release of SeaMonkey 2.53.2 beta(s)

Needed for nss 3.49 and up for now. 2.57 will be hard blocked to only be updateable from 2.53.1 and up.

Not strictly needed patch for browser source extension compatibility with Waterfox classic. Also for porting to SeaMonkey later.

Adjust mozilla-release version numbers in seamonkey release branch.

Adjust comm-release version numbers to 2.53.2 beta 1 pre (done for unofficial version)

Adjust version numbers to SeaMonkey 2.53.2 beta 1
Patch from IanN r/a+ from me.

Beta 1 is now live

The commit Fix detection of cZ language packs as foreign installations
https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/f57408b6a85be4bce9a13341cde34e6e9b4000ff ,
leads to errors at the Lightning update time.

After the update to SM-2.53.2 on a user profile with Lightning enabled, the new Lightning xpi file is copied into the user's profile, but the extension disappears in about:addons .

Web console:

1587066825186	addons.xpi	ERROR	Failed to process extension changes at startup: TypeError: aNewAddon.internalName is null (resource://gre/modules/addons/XPIProvider.jsm -> resource://gre/modules/addons/XPIProviderUtils.js:1269:1) JS Stack trace: addMetadata@XPIProviderUtils.js:1269:1 < processFileChanges@XPIProviderUtils.js:1595:23 < checkForChanges@XPIProvider.jsm:3144:34 < startup@XPIProvider.jsm:2149:25 < callProvider@AddonManager.jsm:259:12 < _startProvider@AddonManager.jsm:729:5 < startup@AddonManager.jsm:896:9 < startup@AddonManager.jsm:3080:5 < observe@addonManager.js:63:9  Log.jsm:750
	App_append resource://gre/modules/Log.jsm:750:9
	log resource://gre/modules/Log.jsm:388:7
	error resource://gre/modules/Log.jsm:396:5
	checkForChanges resource://gre/modules/addons/XPIProvider.jsm:3150:11
	startup resource://gre/modules/addons/XPIProvider.jsm:2149:25
	callProvider resource://gre/modules/AddonManager.jsm:259:12
	_startProvider resource://gre/modules/AddonManager.jsm:729:5
	startup resource://gre/modules/AddonManager.jsm:896:9
	startup resource://gre/modules/AddonManager.jsm:3080:5
	observe jar:file:///usr/local/lib64/seamonkey-2.53.2-0.0/omni.ja!/components/addonManager.js:63:9
While creating services from category 'profile-after-change', could not create service for entry 'calendar-backend-loader', contract ID 'service,@mozilla.org/calendar/backend-loader;1'

Comparing to 2.53.1 source, there is a difference:

--- XPIProviderUtils.js	2020-02-18 02:39:43.000000000 +0300
+++ /home/buc/rpmbuild/BUILD/seamonkey-2.53.2/seamonkey-2.53.2b1/mozilla/toolkit/mozapps/extensions/internal/XPIProviderUtils.js	2020-04-01 14:01:51.000000000 +0300
@@ -1266,7 +1266,7 @@
       aNewAddon.foreignInstall = false;
 
     // Chatzilla language packs should not be treated as a foreign install.
-    if (aNewAddon.type == "locale" && aNewAddon.internalName == "langpack_cZ")
+    if (aNewAddon.type == "locale" && aNewAddon.internalName.startsWith("langpack_cZ"))
       aNewAddon.foreignInstall = false;
 
     if (isDetectedInstall && aNewAddon.foreignInstall) {

IOW, "aNewAddon.internalName" should be checked for NULL.

BTW, cannot find where 2.53.1 receive another variant of the code...

See bug 1630891 and bug 1630896

Closing as 2.53.2 beta is done.