Closed
Bug 163109
Opened 22 years ago
Closed 10 years ago
Should not throw cookie dialogs when fetching favicons
Categories
(Camino Graveyard :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sfraser_bugs, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 obsolete file)
Some sites (e.g. netscape.com) set cookies when you request the favicon, which is undescribably evil. We need to somehow block cookies for these requests, to avoid lots of dialogs popping up for some users.
Reporter | ||
Comment 1•22 years ago
|
||
dougt suggests that I do the URI load with the LOAD_BACKGROUND flag. However, the cookie does not respect this flag, and still throws up cookie dialogs. If the LOAD_BACKGROUND flag is set, then the cookie code should do some default behaviour (reject the cookie??).
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•22 years ago
|
||
Proposed patch.
Comment 3•22 years ago
|
||
Comment on attachment 95618 [details] [diff] [review] nsCookieHTTPNotify.cpp patch r=morse but remove the #ifdef DEBUG_smfr
Updated•22 years ago
|
Attachment #95618 -
Flags: review+
Comment 4•22 years ago
|
||
Can someone explain why a site is attempting to set a cookie when you request its favicon? And what is the consequence of ignoring that for netscape.com? Would we be subverting some revenue-scheme here by rejecting such cookies?
Comment 5•22 years ago
|
||
I really hope you meant to put a smiley face somewhere in that last comment. (T-minus 3 hours till vacation.) Even if there was some kind of money making thing with cookies on a favicon requests, it is orthoganal. The point, is there needs to be a way to request urls without any UI.
Reporter | ||
Comment 6•22 years ago
|
||
Response from request for http://www.netscape.com/favicon.ico: HTTP/1.0 302 Found set-cookie: dcisid=2162760476.1029467957.279324; path=/ P3P: CP="NOI OUR PSA DEV PSD STA" Location: http://wp.netscape.com/favicon.ico MIME-Version: 1.0 Date: Fri, 16 Aug 2002 21:32:30 GMT Server: AOLserver/3.4.2 Content-Type: text/html Content-Length: 311 Connection: close <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <HTML> <HEAD> <TITLE>Redirection</TITLE> </HEAD> <BODY> <H2>Redirection</H2> <A HREF="http://wp.netscape.com/favicon.ico">The requested URL has moved here.</A> <P ALIGN=RIGHT><SMALL><I>AOLserver/3.4.2 on http://www.netscape.com</I></SMALL></P> </BODY></HTML>
Comment 7•22 years ago
|
||
No, I was being dead serious. If my understanding is correct (and maybe it's not), favicon is only for the icon to be displayed along with the URL name. So is there any reason for a site to be sending a set-cookie header along with such a response? In particular, why is netscape doing it? Or is it the case that the netscape server is configured to automatically send back a cookie, and they don't distinguish between a favicon request and a real-content request?
Reporter | ||
Comment 8•22 years ago
|
||
I would guess the latter. Note also the 302 response, which causes us to hit the net every time, rather than relying on the cache. This reeks of poor site management.
Comment 9•22 years ago
|
||
Shouldn't the 'OS' be set to 'Mac OS X'
Reporter | ||
Updated•22 years ago
|
OS: Mac System 9.x → MacOS X
Updated•22 years ago
|
Attachment #95618 -
Flags: needs-work+
Comment 10•22 years ago
|
||
Comment on attachment 95618 [details] [diff] [review] nsCookieHTTPNotify.cpp patch i spoke to simon about this patch... LOAD_BACKGROUND is used when loading other content such as that initiated after the page has finished loading (e.g., content loaded from an onLoad handler, or a mouseover, etc.), so this patch is unfortunately no good. what we really need is some other flag to communicate this to cookies. however, cookies are rather transparent to necko, so adding a new load flag isn't such a great option.
Reporter | ||
Comment 11•22 years ago
|
||
Comment on attachment 95618 [details] [diff] [review] nsCookieHTTPNotify.cpp patch Obsoleting patch
Attachment #95618 -
Attachment is obsolete: true
Comment 12•21 years ago
|
||
Could some one update this bug?
Reporter | ||
Comment 13•21 years ago
|
||
Reassigning to necko folks.
Assignee: sfraser → darin
Status: ASSIGNED → NEW
Comment 14•20 years ago
|
||
Status update? Anyone still looking at this bug? What's the possibility for a 1.0 target?
Reporter | ||
Comment 15•19 years ago
|
||
Darin, any changes here?
Priority: -- → P3
Target Milestone: --- → Camino1.0
Comment 16•19 years ago
|
||
(In reply to comment #15) > Darin, any changes here? > Ping?
Updated•19 years ago
|
Target Milestone: Camino1.0 → Camino1.1
Updated•18 years ago
|
Assignee: darin → nobody
QA Contact: winnie → general
Updated•18 years ago
|
Target Milestone: Camino1.1 → Camino2.0
Updated•17 years ago
|
Target Milestone: Camino2.0 → ---
Comment 17•10 years ago
|
||
This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX. [Mass-change filter: graveyard-wontfix-2014-09-24]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•