Update nsSuiteDirectoryProvider for changes to locale retrieval
Categories
(SeaMonkey :: Startup & Profiles, task)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.3)
Attachments
(1 file)
|
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
We need to update nsSuiteDirectoryProvider for changes to locale retrieval by porting the relevant part of the following bugs:
- Bug 1252627 - distribution defaultLocale should take precedence over user agent locale
- Bug 1299234 - Fix incorrect if statement block in AppendDistroSearchDirs()
- Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none, old method still works
Testing completed (on m-c, etc.): 2.53.3
Risk to taking this patch (and alternatives if risky): none, equivalent code has been sitting in Firefox since 55.
String changes made by this patch: none
|
||
Comment 2•5 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b8c06eb41914
Update nsSuiteDirectoryProvider for changes to locale retrieval. r=frg
|
|
||
Comment 4•5 years ago
|
||
patch landed with minor rebase for blank line removal after if.
|
|
||
Comment 5•4 years ago
|
||
Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b861dd3c68143d8291a3682ee845990413f16b96
Update nsSuiteDirectoryProvider for changes to locale retrieval. r=frg a=frg
|
|
||
Updated•2 years ago
|
Description
•