Closed Bug 1441016 Opened 7 years ago Closed 2 years ago

Migrate to intl.locale.requested.locale list from general.useragent.locale

Categories

(SeaMonkey :: Preferences, enhancement)

Product:
SeaMonkey
Component:
Preferences
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.15)

Attachments

(1 file, 1 obsolete file)

1441016-port1414390-25315.patch
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1423532 +++ As per bug 1414390 comment #28 and further down, we need to port the migration code: https://hg.mozilla.org/mozilla-central/rev/8d88b85d93be#l3.13 We also need to port -pref("general.useragent.locale", "@AB_CD@"); +pref("intl.locale.requested", "@AB_CD@");
tracking-seamonkey2.57esr: --- → ?
Version: SeaMonkey 2.59 Branch → SeaMonkey 2.56 Branch

Tentatively taking this.

Assignee: nobody → rsx11m.pub
Attached patch WIP patch (obsolete) (deleted) — — Splinter Review
Assignee: rsx11m.pub → iannbugzilla
Status: NEW → ASSIGNED
status-seamonkey2.53: --- → affected
tracking-seamonkey2.53: --- → +
Depends on: 1633212
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Port Bug 1414390 "Add intl.locale.requested locale list to replace general.useragent.locale" to SeaMonkey → Migrate to intl.locale.requested.locale list from general.useragent.locale
Version: SeaMonkey 2.56 Branch → Trunk
Attached patch 1441016-port1414390-25315.patch (deleted) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): 1414390
User impact if declined: locale stuff doesn't work properly
Testing completed (on m-c, etc.): 2.53.15
Risk to taking this patch (and alternatives if risky): some
String changes made by this patch: none

Attachment #9183654 - Attachment is obsolete: true
Attachment #9296117 - Flags: review?(frgrahl)
Attachment #9296117 - Flags: approval-comm-release?
Attachment #9296117 - Flags: approval-comm-esr60?

Comment on attachment 9296117 [details] [diff] [review]
1441016-port1414390-25315.patch

Typo needs to be fixed in /suite/components/pref/content/pref-appearance.js:
Services.locales.setRequestedLocales([locale]);

is .locale.

I installed the de language pack and when I deinstalled it I got a blank display in the prefs and needed to reselect the default locale. But something we can deal later if ever.

lgtm. r/a= me with typo fixed.

Attachment #9296117 - Flags: review?(frgrahl)
Attachment #9296117 - Flags: review+
Attachment #9296117 - Flags: approval-comm-release?
Attachment #9296117 - Flags: approval-comm-release+
Attachment #9296117 - Flags: approval-comm-esr60?
Attachment #9296117 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2486062f77ac
Migrate to intl.locale.requested.locale list from general.useragent.locale. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.15

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7b5ed5915df3c4ec66947e0548c77ea2924ef9e7
Migrate to intl.locale.requested.locale list from general.useragent.locale. r=frg a=frg

status-seamonkey2.53: affected → fixed
tracking-seamonkey2.53: ? → +
Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: