Closed
Bug 1633562
Opened 5 years ago
Closed 5 years ago
Ctrl+A from empty recipient input "double-fires" and prematurely selects all rows before current row
Categories
(Thunderbird :: Message Compose Window, defect, P1)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 77.0
People
(Reporter: thomas8, Assigned: aleca)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Screen record from 2020-04-27 14.16.49.gif
+++ This bug was initially created as a clone of Bug #1633287 +++
Ctrl+A from empty recipient input "double-fires" and prematurely selects all rows before current row.
Similar to bug Bug #1633287 where Alex had to prevent some default events to prevent double-firing on other focus-moving keys. Unfortunately, just adding event.preventDefault in onbeforekeydown() for Ctrl+"a" didn't fix this for me, but I'm confident Alex will figure this out ;-)
Expected (as designed):
- First Ctrl+A from empty input selects all pills in current addressing row
- Next Ctrl+A (with all pills of current row selected, and not event.repeat) conveniently selects all pills of all rows
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9143799 -
Flags: review?(mkmelin+mozilla)
Attachment #9143799 -
Flags: feedback?(bugzilla2007)
|
Reporter | |
Comment 2•5 years ago
|
||
Comment on attachment 9143799 [details] [diff] [review]
1633562-select-all-input.diff
Review of attachment 9143799 [details] [diff] [review]:
-----------------------------------------------------------------
As I said, I tried the same and thought it should work, but this does not fix it for me.
Attachment #9143799 -
Flags: feedback?(bugzilla2007) → feedback-
|
|
Assignee | |
Comment 3•5 years ago
|
||
This works as intended for me.
|
|
Reporter | |
Comment 4•5 years ago
|
||
Comment on attachment 9143799 [details] [diff] [review]
1633562-select-all-input.diff
Review of attachment 9143799 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Alessandro Castellani (:aleca) from comment #3)
> This works as intended for me.
It works now for me, too.
Sorry, my mistake, there was something out of sync in my install. Sometimes I feel that the setting "Check for updates, but let me choose whether to install them" is not honoured; instead, it always reverts back to "Automatically install updates".
Attachment #9143799 -
Flags: feedback- → feedback+
|
||
Updated•5 years ago
|
Attachment #9143799 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 77.0
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/53466469a60f
Prevent double firing CTRL+A on an empty recipient input field. r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•