Always attach thread front from toolbox code
Categories
(DevTools :: Debugger, enhancement, P2)
Tracking
(Fission Milestone:M6c, firefox81 fixed)
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: ochameau, Assigned: jdescottes)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(3 files, 1 obsolete file)
We should probably start moving this code to the toolbox, here.
But, to do that we have to somehow be able to access breakpoint locations from the Toolbox code. It means having an access to options.breakpoints from target.js code, i.e. commands.js's breakpoints. That, without having to open the Debugger panel.
This also probably depends on toggling TargetList.listenForWorkers, so that the toolbox get notified about workers targets. And also ensure requesting workers to pause, like this, from Toolbox code. We can probably do better than calling a ThreadActor method, as this is rather related to listWorkers/TargetList.watchTargets([WORKERS]) rather than the thread actor!
The pros of doing all that:
- We attach all thread actors from toolbox code, for all target types
- We support early breakpoints for (service) workers, even if the debugger isn't opened yet
- And ultimately, we will be compatible with fission and early breakpoint. Until we do that, we will break support of early breakpoint in remote frames.
|
||
Comment 1•4 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6) milestone
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Comment 2•4 years ago
|
||
|
|
||
Comment 3•4 years ago
|
||
|
|
||
Comment 4•4 years ago
|
||
Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 5•4 years ago
|
||
Let's try to resume this :)
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D75157
A thread actor attach error shows up as
Protocol error (unknownError): error occurred while processing 'attach':
[object Object] from: server0.conn145.content-process36/workerTarget5/thread1
[object Object] is a legacy {error, message} object thrown by the thread actor
|
|
Assignee | |
Updated•4 years ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/039297a5c7ae Always attach thread front from toolbox code. r=ochameau,nchevobbe https://hg.mozilla.org/integration/autoland/rev/e172ba6bee70 Improve error reporting for legacy actors r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/9d6c24b03c1b Skip attaching thread for already attached thread fronts r=ochameau,nchevobbe
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/039297a5c7ae
https://hg.mozilla.org/mozilla-central/rev/e172ba6bee70
https://hg.mozilla.org/mozilla-central/rev/9d6c24b03c1b
Description
•