Closed Bug 1647354 Opened 4 years ago Closed 4 years ago

Start listening to workers when the TargetList is created

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(Fission Milestone:M7)

RESOLVED FIXED
Fission Milestone M7

People

(Reporter: jlast, Unassigned)

References

Details

Bug 1573327 is moving the thread attaching logic from the debugger to the toolbox. This bug is focused on listening to workers from the beginning.

Here is a few examples of things that should probably be tweaked when toggling this:

  • Toolbox.onTargetAvailable should probably avoid calling startListeners["NetworkActivity"] on worker targets. (It may also be only useful on the top level target)
  • This other code of Toolbox.onTargetAvailable will enable worker in the context selector. But it will be broken for the console until this bug is fixed.

Otherwise, it looks good from the WebConsole codebase.
We do ignore worker targets from WebConsoleUI and from legacy listeners.

So that it may be good to have a dedicated bug to focus on just that.

I think you meant to block 1633727 (both at ending with 27, this is confusing :o)

Blocks: 1633727
No longer blocks: 1573327
Severity: -- → S3
Priority: -- → P3
Whiteboard: dt-fission-m2-reserve

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Fission Milestone: --- → M7

(In reply to Jason Laster [:jlast] from comment #1)

Here is a few examples of things that should probably be tweaked when toggling this:

  • Toolbox.onTargetAvailable should probably avoid calling startListeners["NetworkActivity"] on worker targets. (It may also be only useful on the top level target)

This code moved into the legacy listener for network event.

  • This other code of Toolbox.onTargetAvailable will enable worker in the context selector. But it will be broken for the console until this bug is fixed.

I imagine worker have been added in the context selector via bug 1633727?
And we will fix console support in bug 1633712 or later via bug 1592584.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: dt-fission-m2-reserve
You need to log in before you can comment on or make changes to this bug.