Runtime.executionContextsCleared should only be emitted for top-frame navigation
Categories
(Remote Protocol :: CDP, defect, P1)
Tracking
(firefox79 fixed)
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [puppeteer-beta-reserve])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Right now the event is emitted when all execution contexts for a window have been removed. But that is not correct. Instead it should only be emitted when all contexts of a tab target get removed due to a navigation in the top level browsing context, or when the tab gets closed.
Also when the Runtime gets disabled the event has to be fired.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
This broken behavior on this bug actually blocks my work on bug 1637640. Given that we emit Runtime.executionContextsCleared also for frames Puppeteer looses certain cached execution contexts, and the returned Promise from executionContext() in DOMWorld.js is hanging.
|
|
Assignee | |
Comment 2•4 years ago
|
||
I moved out the part for Runtime.disable into bug 1644661.
|
|
Assignee | |
Comment 3•4 years ago
|
||
This also fixes a hang in Puppeteer's DOMWorld.js when resolving
the current executionContext promise. With the extra event all
the Puppeteer internal contexts for the tab target have been destroyed.
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
Description
•