Closed
Bug 1637640
Opened 4 years ago
Closed 4 years ago
Enable page load events for frames
Categories
(Remote Protocol :: CDP, task, P1)
Remote Protocol
CDP
Tracking
(firefox79 fixed)
RESOLVED
FIXED
Firefox 79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 5 open bugs)
Details
(Whiteboard: [puppeteer-beta-reserve])
Attachments
(3 files)
Right now we disable any page load event for frames:
As result we emit view lesser events than Chrome, and this seems to cause various problems in Puppeteer because event handlers like for Page.frameNavigated rely on the correct frame id and parent frame id:
Which means frames aren't correctly setup internally.
Given that the Page domain also makes use of the context observer, it has to be built upon the patches on bug 1593226.
|
||
Updated•4 years ago
|
Whiteboard: [puppeteer-beta-mvp] → [puppeteer-beta-reserve]
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59cd08b79678 [remote] Enable page load events for frames. r=remote-protocol-reviewers,maja_zf https://hg.mozilla.org/integration/autoland/rev/3fb7f441b1c1 [remote] Update Puppeteer expectation data. r=remote-protocol-reviewers,maja_zf
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/59cd08b79678
https://hg.mozilla.org/mozilla-central/rev/3fb7f441b1c1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
|
||
Updated•4 years ago
|
Component: CDP: Page → CDP
You need to log in
before you can comment on or make changes to this bug.
Description
•