Closed
Bug 1638533
Opened 5 years ago
Closed 5 years ago
Show (in promise) for uncaught promise rejections
Categories
(DevTools :: Console, enhancement)
DevTools
Console
Tracking
(firefox78 fixed)
RESOLVED
FIXED
Firefox 78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: evilpie, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Nicolas said he wanted to add "(in promise)" to uncaught promise rejections logged to the console like Chrome. With my patch in bug 1636590, nsIScriptError now has isPromiseRejection that could be used by the devtools team to implement this.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
Now that nsIScriptError have a isPromiseRejection flag, we can consume it
in the console to indicate to the user that we're dealing with a promise rejection.
The exception message is then: "Uncaught (in promise) XXX".
A few tests needed to be updated, and we take this as an opportunity to
ensure we have a stacktrace for uncaught promise rejection.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc1d9c3a3167
Add (in promise) suffix for uncaught rejected promise. r=davidwalsh.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in
before you can comment on or make changes to this bug.
Description
•