Closed Bug 1639305 Opened 5 years ago Closed 5 years ago

Perma devtools/client/webconsole/test/browser/browser_webconsole_promise_rejected_object.js | Uncaught exception when Gecko 78 merges to Beta on 2020-06-01

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(firefox-esr68 unaffected, firefox76 unaffected, firefox77 unaffected, firefox78+ verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 78
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 + verified

People

(Reporter: aryx, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1639305 - Fix beta simulation failure in browser_webconsole_promise_rejected_object.js. r=evilpie.
(deleted), text/x-phabricator-request
Details

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=cTPBJkRZR_ikSHRIoT-6Ag-0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=e825575f0b8018f08665384d7afcdce01d14b0e8

This fails mostly on shippable opt.

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=302910289&repo=try

[task 2020-05-19T14:16:09.137Z] 14:16:09 INFO - TEST-START | devtools/client/webconsole/test/browser/browser_webconsole_csp_violation.js
[task 2020-05-19T14:16:10.408Z] 14:16:10 INFO - GECKO(6305) | console.log: test-csp-violation-base-uri.html:15:24
[task 2020-05-19T14:16:10.448Z] 14:16:10 INFO - GECKO(6305) | JavaScript error: https://example.com/browser/devtools/client/webconsole/test/browser/test-csp-violation-form-action.html, line 14: :
[task 2020-05-19T14:16:10.849Z] 14:16:10 INFO - GECKO(6305) | DevToolsUtils.assert threw an exception: Error: Assertion failure: Target must not be exited to create a sheet actor.
[task 2020-05-19T14:16:10.850Z] 14:16:10 INFO - GECKO(6305) | Stack: reallyAssert@resource://devtools/shared/DevToolsUtils.js:407:17
[task 2020-05-19T14:16:10.853Z] 14:16:10 INFO - GECKO(6305) | createStyleSheetActor@resource://devtools/server/actors/targets/browsing-context.js:1521:11
[task 2020-05-19T14:16:10.854Z] 14:16:10 INFO - GECKO(6305) | _getImported/<@resource://devtools/server/actors/stylesheets.js:839:42
[task 2020-05-19T14:16:10.854Z] 14:16:10 INFO - GECKO(6305) | Line: 407, column: 17
[task 2020-05-19T14:16:10.856Z] 14:16:10 INFO - GECKO(6305) | console.error: (new Error("Assertion failure: Target must not be exited to create a sheet actor.", "resource://devtools/shared/DevToolsUtils.js", 407))
[task 2020-05-19T14:16:10.856Z] 14:16:10 INFO - GECKO(6305) | console.error: "Error while calling actor 'stylesheets's method 'getStyleSheets'" "Assertion failure: Target must not be exited to create a sheet actor."
[task 2020-05-19T14:16:10.856Z] 14:16:10 INFO - GECKO(6305) | console.error: "reallyAssert@resource://devtools/shared/DevToolsUtils.js:407:17\ncreateStyleSheetActor@resource://devtools/server/actors/targets/browsing-context.js:1521:11\n_getImported/<@resource://devtools/server/actors/stylesheets.js:839:42\n"

Actually, it failed on the same platforms for the central-as-late-beta simulation.

Summary: Frequent devtools/client/webconsole/test/browser/browser_webconsole_promise_rejected_object.js | Uncaught exception when Gecko 78 merges to Beta on 2020-06-01 → Perma devtools/client/webconsole/test/browser/browser_webconsole_promise_rejected_object.js | Uncaught exception when Gecko 78 merges to Beta on 2020-06-01

Tom, is the stacktrace retrieval for promise rejection behind a pref or something?
The failure screenshot seems to indicate we don't have them in Beta simulation: https://firefoxci.taskcluster-artifacts.net/cTPBJkRZR_ikSHRIoT-6Ag/0/public/test_info//mozilla-test-fail-screenshot_HHNYHf.png

Flags: needinfo?(nchevobbe) → needinfo?(evilpies)

Yes. It is actually! We need to set javascript.options.asyncstack like we did in bug 1638549.

Flags: needinfo?(evilpies)

okay thanks! Let me do that

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

The javascript.options.asyncstack pref is needed for unhandled
rejected promises messages to have a stacktrace.

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33b80df7aede Fix beta simulation failure in browser_webconsole_promise_rejected_object.js. r=evilpie.

https://hg.mozilla.org/mozilla-central/rev/33b80df7aede

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: