Closed
Bug 1641839
Opened 5 years ago
Closed 5 years ago
Only emit Page.frameAttached and Page.frameAttached for frames
Categories
(Remote Protocol :: CDP, defect, P1)
Remote Protocol
CDP
Tracking
(firefox77 unaffected, firefox78 wontfix, firefox79 fixed)
RESOLVED
FIXED
Firefox 79
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | unaffected |
| firefox78 | --- | wontfix |
| firefox79 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [puppeteer-beta-reserve])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
With the implementation of both the the Page.frameAttached and Page.frameDetached methods we now emit those events even for opened popup windows, and maybe new tabs/targets.
This causes some Puppeteer tests like this one to fail when the remote.frames.enabled preference has been turned enabled.
The fix will be easy. Just make sure that there is a parent browsing context for the docshell as observed via the webnavigation-create and webnavigation-destroy notifications.
|
Assignee | |
Updated•5 years ago
|
Keywords: regression
|
|
Assignee | |
Updated•5 years ago
|
Severity: -- → S3
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6fd4b85734e
[remote] Only emit Page.frameAttached and Page.frameAttached for frames. r=remote-protocol-reviewers,maja_zf
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
Component: CDP: Page → CDP
You need to log in
before you can comment on or make changes to this bug.
Description
•