Closed Bug 1648732 Opened 4 years ago Closed 4 years ago

Crash in AudioResampler

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

All
Unspecified
defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

Details

Attachments

(1 file)

The crash is reproduced only with a gtest. It came up accidentally and revealed a problem in AudioResampler used as a part of AudioDriftCorrection. I have been using AudioDriftCorrection for some time now, in real life, and I have not come across it so I guess the crash rate is low. However, we need to fix in the run up to pref on setsinkid.

In AudioResampler the resampling of a buffer happens on pieces of 128 or 256 frames. Before resampling, the number of available frames is checked for the whole buffer and for the individual smaller pieces. When the whole buffer is checked we need to check for one extra frame in order to compensate the case that one individual resampling has consumed an extra frame, something that is normal and happens periodically.

Assignee: nobody → achronop
Status: NEW → ASSIGNED
Pushed by achronopoulos@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ec0bb98c893 Fine tune the check for available frames in AudioResampler. r=padenot
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: