Enable by default setSinkId pref
Categories
(Core :: Audio/Video, enhancement, P3)
Tracking
()
People
(Reporter: achronop, Assigned: karlt)
References
(Depends on 1 open bug, Blocks 3 open bugs)
Details
(Keywords: dev-doc-complete, Whiteboard: [wfh][jitsi-meet])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Reporter | ||
Comment 3•6 years ago
|
||
I tested it again and now it works. Perhaps Firefox needs a restart to make the config effective?
Updated•6 years ago
|
Comment 5•5 years ago
|
||
The pref has this comment: "setSinkId expected to be unconditionally enabled in 63". That clearly didn't happen, so in bug 1490044 I'm updating the comment to "setSinkId will be enabled in bug 1498512".
Any update on this one? It's working great, it'd be really better for our users to enable it by default at this stage
Reporter | ||
Comment 7•5 years ago
|
||
We keep it off because it does not work for everything. It works when we playback a file but not for webaudio or WebRTC. We want to add those too and we keep it off till then. Just curious, have you used online or you are testing locally?
Ha, missed that indeed I was only testing the UI itself. We are intending to use it for a WebRTC meeting app so that's key. We have seen that many users need to manually change their mix of microphone + speaker, and as a result setSinkId is essential to ensure that headsets users have audio coming in & out from the same device.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Tried this just now on meet.google.com with the pref media.setsinkid.enabled
set to True on MacOS 10.15.3 (19D76) with Firefox Nightly 76.0a1 (2020-03-29) (64-bit)
It does not work for WebRTC during the call but does work for the 'Test' audio bit (likely a local file)
What's the status?
Reporter | ||
Comment 11•5 years ago
|
||
We are missing Bug 1493990 for the full functionality. Normal playback works, like the test you did or video/audio playback from youtube or any other service. The rest of the functionality that will cover WebRTC and any other MediaStream is coming. I have been working actively on it for some time now.
Updated•5 years ago
|
Updated•4 years ago
|
Comment 14•4 years ago
|
||
DOCS TEAM: When this is done, we need to also remove this from the "Experimental features in Firefox" page.
Comment 17•4 years ago
|
||
Looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1661649 fixed.
Any progress on this bug?
Comment 18•4 years ago
|
||
You can see the dependency tree for this bug. Most notably bug 1493982 is a blocker.
Comment 19•4 years ago
|
||
In Safari Tech Preview 115
https://webkit.org/blog/11333/release-notes-for-safari-technology-preview-115/
https://trac.webkit.org/changeset/267472/webkit/
Added support for HTMLMediaElement.setSinkId (r267472)
Comment 20•4 years ago
|
||
Hello,
I'm not sure if this is the right place to report this bug, but when I set that I want to use my headset in Google Meet's settings whereas my system is using my laptop speaker, the sound comes out of my laptop speaker. Google Meet's settings sound playing test, however, comes out of my headset.
Yann
Comment 21•4 years ago
|
||
(In reply to Yann Soubeyrand from comment #20)
Hello,
I'm not sure if this is the right place to report this bug, but when I set that I want to use my headset in Google Meet's settings whereas my system is using my laptop speaker, the sound comes out of my laptop speaker. Google Meet's settings sound playing test, however, comes out of my headset.
Yann
I took a look and they don't seem to be calling setSinkId properly. It worked fine when I called setSinkId manually on the appropriate audio element. When we ship setSinkId we'll require selectAudioOutput also, so they need to do some work to comply with the latest spec either way. I reckon they'll fix this when they go through that process.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 24•1 year ago
|
||
Assignee | ||
Comment 25•1 year ago
|
||
Comment 26•1 year ago
|
||
Comment 27•1 year ago
|
||
bugherder |
Comment 28•1 year ago
|
||
:karlt, now that this is enabled by default in 116, can you nominate this for release notes?
Assignee | ||
Comment 29•1 year ago
|
||
Thank you for the reminder.
Release Note Request (optional, but appreciated)
[Why is this notable]: New web platform feature potentially affecting user experience.
[Affects Firefox for Android]: No.
[Suggested wording]:
The Audio Output Devices API now enables sites to redirect audio from media elements to permitted output devices (speakers) other than the system default for the user-agent.
For example, WebRTC conferencing sites can now redirect audio either to the speakers in a headset or to external speakers.
[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/selectAudioOutput
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/setSinkId
Comment 30•1 year ago
|
||
thank you! added to https://www.mozilla.org/en-US/firefox/116.0beta/releasenotes/
Comment 31•1 year ago
|
||
FF116 Docs work can be tracked in https://github.com/mdn/content/issues/27748. Near complete except reviews.
Comment 32•1 year ago
|
||
\o/ woot!
Updated•1 year ago
|
Updated•1 year ago
|
Description
•