Open Bug 1653891 Opened 4 years ago Updated 4 years ago

Autofill not working well when an origin is dominating others or websites change origin often.

Categories

(Firefox :: Address Bar, defect, P3)

78 Branch
defect

Tracking

()

People

(Reporter: pqwoerituytrueiwoq, Unassigned)

References

Details

Attachments

(3 files)

Attached file Reproduction.zip (deleted) —

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

noticed autocomplete in the address bar was not working on site i often
normally i use Ctrl+L and type 'ani' and it autocompletes, this no longer happens
if i delete my browser history for imgur it suddenly works again

I have attached a sanitized copy of places.sqlite in the zip file along with a recording of the issue

  • be aware I do browser user sub on imgur at times, if you go opening random imgur links from my history you have been warned
  • I have deleted some data using a sqlite db editor in addition to deleting it from within firefox (bookmarks and history) as i do not plan on posting my browser history

Actual results:

When I type ani into the address bar nothing is auto-completed and it defaults to search the web, deleting imgur browser history should not have any effect on this

Expected results:

When I type ani into the address bar it should autocomplete the domain name

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Address Bar

The "ani" autofill doesn't happen because it doesn't clear the autofill threshold, and it doesn't clear the autofill threshold because, for some reason, imgur is dominating the database with some extreme high scores. Do you have some add-ons opening imgur links or such?

You can likely workaround the problem bookmarking the animeseries page, then it should be filled regardless.

We should try to better understand if this situation is caused by automated tools, or if you can reach this state with normal browsing due to some use-case we didn't consider well. For this any information you can give us about your workflow would be precious.

Flags: needinfo?(pqwoerituytrueiwoq)

The only addons i have installed (and active) on my main profile are nano adblocker, noscript, tabsearch, and tampermonkey
the only work around i found was to create a bookmark and also set the keyboard to ani (this does not autocomplete, but it has the same end result)
the test profile has 0 addons
i have no addons (or scripts) that open links

my browser history goes back to when i updated from firefox 52 esr when that version reached EOL and a made a clean profile

if score refers to the moz_orgins table, here are some metrics for scale
youtube has a frequency of 19144895
google has a frequency of 10747241
reddit has a frequency of 10228430

the one site i was having this issue with has changes it top and sub level domain like the seasons change, this probably causes the frequency to essentially reset periodically and thus causing other sites to vastly outrank it over time

if the moz_orgins table is important i will remove a few entries and add it to the report

after looking at some other domains i use i noticed a bank's website does not autocomplete it has a frequency of 56307, i have been using that account for around 13 months now, so i guess it does not autocomplete since i have years of history outweighing it

Flags: needinfo?(pqwoerituytrueiwoq)

(In reply to pqwoerituytrueiwoq from comment #3)

the only work around i found was to create a bookmark and also set the keyboard to ani (this does not autocomplete, but it has the same end result)

this is strange, we should autofill the origin for the bookmark regardless of the threshold.
Something particular in this case is that the domain redirects from animeseries.co to www5.animeseries.io, but also typing "www5.a" doesn't fill if the page is bookmarked. We should probably do something about the wwwN cases anyway.

the one site i was having this issue with has changes it top and sub level domain like the seasons change, this probably causes the frequency to essentially reset periodically and thus causing other sites to vastly outrank it over time

yes, that's likely.

if the moz_orgins table is important i will remove a few entries and add it to the report

I think the current one is ok to start investigation.

after looking at some other domains i use i noticed a bank's website does not autocomplete it has a frequency of 56307, i have been using that account for around 13 months now, so i guess it does not autocomplete since i have years of history outweighing it

The score should build up quickly, in far less than 13 months, so there still seem to be something wrong there, maybe the score is not decaying properly for unvisited pages, or the sums are wrong for origins.

Could you please attach a log from about:support, so we can also check the status of other important preferences.

Flags: needinfo?(pqwoerituytrueiwoq)

if that assumption is correct why would raspberrypipbx.blogspot.com autocomplete with a frequency of 38
note that www.raspberrypi.org has a score of 143096 and will not even autocomplete with 'www.ras'

Flags: needinfo?(pqwoerituytrueiwoq)
Attached file about-support-raw.json (deleted) —

I think the problem is the query is wrongly extracting the "bookmarked" value.
In this case there are both an http and https entries in moz_origins, the "GROUP BY host" constructs at https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/browser/components/urlbar/UrlbarProviderAutofill.jsm#113,128 are picking just one of those entries, and checking for bookmarks https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/browser/components/urlbar/UrlbarProviderAutofill.jsm#105-107
That is not going to check both origins, but only one, and if it's the non-bookmarked one, we hit the bug.

Severity: -- → S2
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P1
Summary: Address bar autocomplete not working 100% → Autofill not working for some bookmarked origins

note turns out that raspberrypipbx.blogspot.com is bookmarked
is there anything other than ctrl+d that can make bookmarks? i noticed i have a silly amount of ones i never made or maybe it just hit ctrl+d on accident a lot

Sync if you connect other devices with bookmarks in them, CTRL+D, clicking on the star button, and add-ons can also create bookmarks.

I'm looking into the query atm, so it may not be necessary to make changes on your side apart from bookmarking. Fixing the query won't fix this bug from the point of view of the threshold, but at least should provide a valid workaround.

I'm not sure how to express the frecency skew we see, but I'll file the bookmarks bug as a dependency, because that's something more easily fixable, leaving this open for frecency investigation.

Summary: Autofill not working for some bookmarked origins → Autofill not working well when an origin is dominating others or websites change origin often.
Severity: S2 → S3
Priority: P1 → P3
Depends on: 1654316

maybe it is sync with my laptop
it is very rare i make a bookmark and i normally only do so for berried pages or for something i know i will forget

making a bookmark for my bank make autocomplete work

Would the moz_orgins table be useful for the scaling issue?

Severity: S3 → S2
No longer depends on: 1654316
Priority: P3 → P1
Summary: Autofill not working well when an origin is dominating others or websites change origin often. → Autofill not working for some bookmarked origins
Severity: S2 → S3
Depends on: 1654316
Priority: P1 → P3
Summary: Autofill not working for some bookmarked origins → Autofill not working well when an origin is dominating others or websites change origin often. → Autofill not working for some bookmarked origins
Summary: Autofill not working well when an origin is dominating others or websites change origin often. → Autofill not working for some bookmarked origins → Autofill not working well when an origin is dominating others or websites change origin often.
Attached file moz_orgins_sensord.zip (deleted) —

Sample data may helps with skewing the algorithm for what domains get autofilled
4 domains are over 10m, another 4 are 1-7m, this really overshadows stuff that should autofill around 15k - 60k

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: