Autofill is not properly considering bookmarked status of origins
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
From https://bugzilla.mozilla.org/show_bug.cgi?id=1653891#c7
I think the problem is the query is wrongly extracting the "bookmarked" value.
In this case there are both an http and https entries in moz_origins, the "GROUP BY host" constructs at https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/browser/components/urlbar/UrlbarProviderAutofill.jsm#113,128 are picking just one of those entries, and checking for bookmarks https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/browser/components/urlbar/UrlbarProviderAutofill.jsm#105-107
That is not going to check both origins, but only one, and if it's the non-bookmarked one, we hit the bug.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
The old query was picking a random bookmarked status out of the pages in an origin,
depending on the physical position of the origin rows in the table.
The new query uses window functions to partition the data by origin, so it can
query origins just once and sum www and non-www origin's frecency scores before
comparing to the autofill threshold.
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•