[Mac] Empty menuitem in File menu
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: stefanh, Assigned: iannbugzilla)
References
(Regression)
Details
(Whiteboard: SM2.53.4)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
stefanh
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
empty_menuitem.png
On Mac, the "menu_printPreview" menuitem shows up empty in the file menu. It shouldn't be there at all. My guess is that it shows up because it exists in various files, but only non-mac will get a label (and other stuff, like a command) from utilityOverlay.xul (the old platformoverlay that was removed had <menuitem id="menu_printPreview" hidden="true"/>)
Side note: I should have noticed this earlier...
|
Reporter | |
Comment 1•4 years ago
|
||
[Approval Request Comment]
Regression caused by (bug #): 1611714
User impact if declined: Blank line in File menu on mac
Testing completed (on m-c, etc.): 2.53.4
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
|
|
Reporter | |
Comment 3•4 years ago
|
||
|
||
Comment 4•4 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c666f225f822
[Mac] Empty menuitem in File menu. f=stefanh
|
|
||
Updated•4 years ago
|
|
|
||
Comment 6•4 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/36d292f417c177378dc2eeb3146b714c448badc8
[Mac] Empty menuitem in File menu. r=stefanh a=frg
Target 2.53.4
Description
•