Closed Bug 1611714 Opened 5 years ago Closed 5 years ago

Remove platform overlays

Categories

(SeaMonkey :: UI Design, task)

Product:
SeaMonkey
Component:
UI Design
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.72
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.2)

Attachments

(3 files, 2 obsolete files)

Remove mailnews platform overlays
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Remove browser platform overlay
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Remove common platform overlays v1.2
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

At the moment SeaMonkey makes use of platform overlays, other applications use preprocessing so SeaMonkey should too. Added bonus is that should simplify the code and make porting of patches easier.

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: none
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9123122 - Flags: review?(frgrahl)
Attachment #9123122 - Flags: approval-comm-release?
Attachment #9123122 - Flags: approval-comm-esr60?
Attached patch Remove browser platform overlay (deleted) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: none
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: strings can be copied from existing files into navigatorOverlay.dtd

This patch goes on top of the mailnews patch

Attachment #9123123 - Flags: review?(frgrahl)
Attachment #9123123 - Flags: approval-comm-release?
Attachment #9123123 - Flags: approval-comm-esr60?
Attached patch Remove common platform overlays (obsolete) (deleted) — — Splinter Review

Regression caused by (bug #): none
User impact if declined: none
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: strings can be copied from existing files into new locations

This applies on top of mailnews and browser patches

Attachment #9123233 - Flags: review?(frgrahl)
Attachment #9123233 - Flags: approval-comm-release?
Attachment #9123233 - Flags: approval-comm-esr60?
Attached patch Remove common platform overlays v1.1 (obsolete) (deleted) — — Splinter Review

Fixed missing preferencesCmdMac.label entity

Attachment #9123233 - Attachment is obsolete: true
Attachment #9123233 - Flags: review?(frgrahl)
Attachment #9123233 - Flags: approval-comm-release?
Attachment #9123233 - Flags: approval-comm-esr60?
Attachment #9124490 - Flags: review?(frgrahl)
Attachment #9124490 - Flags: approval-comm-release?
Attachment #9124490 - Flags: approval-comm-esr60?

Update entity names in pref-mousewheel to help localisers spot the changes

Attachment #9124490 - Attachment is obsolete: true
Attachment #9124490 - Flags: review?(frgrahl)
Attachment #9124490 - Flags: approval-comm-release?
Attachment #9124490 - Flags: approval-comm-esr60?
Attachment #9124506 - Flags: review?(frgrahl)
Attachment #9124506 - Flags: approval-comm-release?
Attachment #9124506 - Flags: approval-comm-esr60?
Comment on attachment 9123122 [details] [diff] [review] Remove mailnews platform overlays LGTM
Attachment #9123122 - Flags: review?(frgrahl)
Attachment #9123122 - Flags: review+
Attachment #9123122 - Flags: approval-comm-release?
Attachment #9123122 - Flags: approval-comm-release+
Attachment #9123122 - Flags: approval-comm-esr60?
Attachment #9123122 - Flags: approval-comm-esr60+
Comment on attachment 9123123 [details] [diff] [review] Remove browser platform overlay LGTM
Attachment #9123123 - Flags: review?(frgrahl)
Attachment #9123123 - Flags: review+
Attachment #9123123 - Flags: approval-comm-release?
Attachment #9123123 - Flags: approval-comm-release+
Attachment #9123123 - Flags: approval-comm-esr60?
Attachment #9123123 - Flags: approval-comm-esr60+
Comment on attachment 9124506 [details] [diff] [review] Remove common platform overlays v1.2 LGTM
Attachment #9124506 - Flags: review?(frgrahl)
Attachment #9124506 - Flags: review+
Attachment #9124506 - Flags: approval-comm-release?
Attachment #9124506 - Flags: approval-comm-release+
Attachment #9124506 - Flags: approval-comm-esr60?
Attachment #9124506 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/22a5fb217b93
Remove platform overlays - mailnews platform overlays. r=frg DONTBUILD
https://hg.mozilla.org/comm-central/rev/6bd591e79a2e
Remove platform overlays - browser platform overlay. r=frg DONTBUILD
https://hg.mozilla.org/comm-central/rev/fdb6e75b389e
Remove platform overlays - common platform overlays. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
status-seamonkey2.49esr: --- → wontfix
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → affected
Target Milestone: --- → seamonkey 2.72
Regressions: 1641038
Regressions: 1654042
status-seamonkey2.53: affected → fixed
status-seamonkey2.57esr: affected → fixed
Whiteboard: SM2.53.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: