Closed
Bug 1655124
Opened 4 years ago
Closed 4 years ago
Add recommendations to Save to Pocket
Categories
(Firefox :: Pocket, enhancement, P1)
Firefox
Pocket
Tracking
()
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: gsuntop, Assigned: thecount)
References
(Depends on 4 open bugs, Blocks 1 open bug)
Details
Attachments
(2 files)
If we display recommendations when users save an article, we can help users discover content and acquire more unique users.
SPEC: https://docs.google.com/document/d/1TNavHbgW52yQfgSA3IZtBOZMujX8r0uzliS0SR2w5mA/edit
Reporter | ||
Updated•4 years ago
|
Assignee: nobody → sdowne
Reporter | ||
Updated•4 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•4 years ago
|
||
Reporter | ||
Updated•4 years ago
|
Iteration: --- → 81.2 - Aug 10 - Aug 23
Reporter | ||
Updated•4 years ago
|
Iteration: 81.2 - Aug 10 - Aug 23 → 82.1 - Aug 24 - Sep 6
Assignee | ||
Comment 2•4 years ago
|
||
To run the tests, run this command: ./mach test browser/components/pocket/test/unit/
Assignee | ||
Comment 3•4 years ago
|
||
To test the functionality, it's a bit tricky because nothing happens with it yet, but you can verify it with a breakpoint.
- Set extensions.pocket.onSaveRecs to true
- Restart.
- Ensure you can see the multi process debugger.
- Log into a Pocket account.
- Open up a Pocket story. Ideally on that is known to Pocket already, I use stories on newtab.
- We're going to add a breakpoint to pocket/main.js, but because it's loaded lazily, you need to trigger a save once to enable it, so we can find it, and add the breakpoint. So save a story now.
- Now in the multi process browser toolbox, look for and open the debugger tab.
- In the sources window on the left, open Main Thread > chrome:// > content > main.js
- Go to line 277, and add a breakpoint.
- Trigger another save on that article.
Expected: it should hit the breakpoint you just set. The data you want to inspect should be in data.recommendations
, it is an array, and should have 3 items.
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/858282dd490f
Show similar recs when a page is saved to Pocket. r=gvn
Comment 5•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Assignee | ||
Comment 6•4 years ago
|
||
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/a89fc9a55c2d
Creating enough structure to start attaching save to Pocket on save recs telemetry. r=gvn
Comment 8•4 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•