Pocket fails to add tags from URL bar button
Categories
(Firefox :: Pocket, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | --- | unaffected |
firefox82 | --- | verified |
People
(Reporter: Fanolian+BMO, Assigned: thecount)
References
(Regression)
Details
(Keywords: nightly-community, regression, reproducible)
Attachments
(1 file)
(deleted),
image/png
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0
Build ID: 20200903151816
Steps to reproduce
- In a new profile, log in to Pocket from https://app.getpocket.com/
- Open a new tab, visit any site. (Actually you can use the same Pocket tab.)
- Click the
Save to Pocket
button on the URL bar.
In theAdd Tags
field, enter any tag. (You don't have to pre-create a tag; it will create one for you) - Press
Save
. - Go back to Pocket tab and observe the newly added item.
Actual result
The item is added but without the assigned tag. In Browser Console this error is generated when I press Save
:
(see the attached screenshot for better formatting)
Uncaught TypeError: can't access property "apiRequest", this is undefined pktApi.jsm:522:5
sendActions chrome://pocket/content/pktApi.jsm:522
sendAction chrome://pocket/content/pktApi.jsm:511
addTags chrome://pocket/content/pktApi.jsm:610
addTagsToURL chrome://pocket/content/pktApi.jsm:562
registerEventMessages chrome://pocket/content/main.js:607
addMessageListener chrome://pocket/content/main.js:813
sendMessage chrome://pocket/content/panels/js/messages.js:67
sendMessage chrome://pocket/content/panels/js/saved.js:632
initAddTagInput chrome://pocket/content/panels/js/saved.js:378
jQuery 8
dispatch
handle
add
on
each
each
on
b
initAddTagInput chrome://pocket/content/panels/js/saved.js:354
create chrome://pocket/content/panels/js/saved.js:597
create chrome://pocket/content/panels/js/saved.js:660
<anonymous> chrome://pocket/content/panels/js/saved.js:722
responseListener chrome://pocket/content/panels/js/messages.js:53
addMessageListener chrome://pocket/content/panels/js/messages.js:26
sendMessageToPanel chrome://pocket/content/main.js:848
sendResponseMessageToPanel chrome://pocket/content/main.js:853
registerEventMessages chrome://pocket/content/main.js:671
addMessageListener chrome://pocket/content/main.js:813
sendMessage chrome://pocket/content/panels/js/messages.js:67
sendMessage chrome://pocket/content/panels/js/saved.js:632
<anonymous> chrome://pocket/content/panels/js/saved.js:708
jQuery 8
j
fireWith
ready
I
promise
<anonymous>
<anonymous>
<anonymous>
Expected result
A tag is assigned to the newly added item.
Notes
- I can still create or assign tags from Pocket's page. It does not work only from Firefox's URL bar button.
- I log in to my Pocket account by email, not a Firefox Account.
- Relevant locale settings according to about:support:
Internationalization & Localization
Application Settings
Requested Locales ["en-US"]
Available Locales ["en-US"]
App Locales ["en-US"]
Regional Preferences ["en-HK"]
Default Locale "en-US"
Operating System
System Locales ["en-US","zh-Hant-HK"]
Regional Preferences ["en-HK"]
From Mozregression:
Last good Nightly: 2020-09-01
First bad Nightly: 2020-09-02
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4a18696ce81f949bd4fea1a68966a4e335d8fbad&tochange=aa032cbc94551a0f6e7e821d78aa0388f998e830
Bisecting autoland builds:
pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d7a942097d6e992ed52350a0957374c4ee6129f&tochange=858282dd490f7cc3001fb76fd1be715c139fa357
It is regressed by bug 1655124.
[Tracking Requested - why for this release]:
It severely affects the workflow for Pocket users. Also the Save to Pocket
button is one of few visible by default buttons in the URL bar.
Additional note
The issue is present whether extensions.pocket.onSaveRecs
is true
or false
.
Comment 4•4 years ago
|
||
Set release status flags based on info from the regressing bug 1655124
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Should be fixed in bug 1663028
Comment 6•4 years ago
|
||
Fanilian can you verify this in today's nightly (build id 20200911093056)?
(In reply to Julien Cristau [:jcristau] from comment #6)
Fanilian can you verify this in today's nightly (build id 20200911093056)?
Fixed in 20200911093056. Thanks a lot.
Description
•