Awesome Bar autocompletes "w" to "woogle.com", but highlights "www.google.com" as a match
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox78 | --- | unaffected |
firefox79 | --- | unaffected |
firefox80 | + | verified |
firefox81 | --- | verified |
People
(Reporter: dustin, Assigned: mak)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0
Steps to reproduce:
Open a new tab and begin entering www
(or anything beginning with a w
.)
Actual results:
Shortly after I enter the first w
, it autocompletes oogle.com
.
The dropdown displays "http://www.google.com". As I add more w
s, it overstrikes oogle.com
and I'll end up with wwwgle.com
. See attached screenshots.
If I type too fast (as in wnc
, web
), it will destroy nc
and eb
and also replace them with gle.com
.
Expected results:
It should not do that.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
Reporter | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
[Tracking Requested - why for this release]: Evident autofill regression, mostly visual but very confusing for the user
I can reproduce typing ww, I wonder if it's related to bug 1654316
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
A poorly thought fixup SQL condition was stripping "www." from the origin in any
case, but when the search string contained "www.".
This ended up stripping too often, for example when typing "w" and matching
against "www.mozilla.org".
Instead, the query should strip "www." from the origin only if it doesn't start
with the search string.
Comment 6•4 years ago
|
||
bugherder |
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 9166308 [details]
Bug 1655363 - Autofill is wrongly fixing up origins in certain cases. r=adw
Beta/Release Uplift Approval Request
- User impact if declined: autofill makes up and shows non-existing origins to the user. The final navigation is correct but the urlbar string is not.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0 has steps, I could also reproduce easily just by typing "w" in a new profile, it autofills to "wozilla.org".
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): this is fixing a simple if condition in the sql query that builds the matching string and has an automated test.
- String changes made/needed:
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Comment on attachment 9166308 [details]
Bug 1655363 - Autofill is wrongly fixing up origins in certain cases. r=adw
approved for 80.0b1
Comment 9•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Comment 10•4 years ago
|
||
I have reproduced this issue using Firefox 81.0a1 (2020.07.25) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 81.0a1 (2020.07.28) and 80.0b1 on Windows 8.1 x64, Ubuntu 18.04 x64 and macOS 10.15.
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Description
•