Closed Bug 1656086 Opened 4 years ago Closed 4 years ago

[Fission] scrolling doesn't work in add-on

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1688096
Fission Milestone M7
Tracking Status
firefox79 --- unaffected
firefox80 --- unaffected
firefox81 --- disabled
firefox82 --- disabled
firefox83 --- disabled
firefox84 --- disabled
firefox85 --- disabled
firefox86 --- disabled

People

(Reporter: kernp25, Unassigned)

References

Details

(Keywords: regression)

Attachments

(5 files)

Attached video QS3PtaZIYh.mp4 (deleted) —

STR:

  1. Start Nightly in fission mode
  2. Install https://addons.mozilla.org/firefox/addon/to-google-translate/
  3. Click on the browser action icon from the installed extension

AR:
Scrolling does not work (the scrollbar is not moving). Clicking on links does nothing etc.

Flags: needinfo?(rob)
Attached video tF6lkxpZVv.mp4 (deleted) —

Web page is working correctly in a Non-Fission window.

Hello,

I’ve managed to reproduce the issue on the latest Nightly (81.0a1/20200730215452) only, under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS. As mentioned in the provided STR, the browser must be started with fission enabled, so for this I’ve set the fission.autostart pref to true and restarted the browser. I’ve only managed to test this on Nightly as on Beta and Release this pref is locked and cannot be changed. Dev Edition and Unbranded versions of Beta and Release also have this pref locked.

I’ve also searched for a regression window and narrowed it down to the 2019-04-17 build, however further bisecting was not possible as mozregression could not find any more builds to test (mozregression has been acting up lately for some reason). This is the corresponding pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b8f49a14c458f56a6a08e4c177671108e386be3a&tochange=02b89c29412b6c1444fe32a4847e5261e2bb3d00 .

Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true

I'll investigate

Please don't needinfo Rob on every issue.

Flags: needinfo?(rob) → needinfo?(tomica)
Attached image f8Gd6val15.png (deleted) —

My other add-on also does not work and is not correctly displayed in the popup. There is a space on the right side.

Tracking for Fission Nightly M6c

Severity: -- → S3
Fission Milestone: --- → M6c
Priority: -- → P3

Fission is disabled in 81.

This is the same as bug 1646817 for which I'm testing a patch, so marking as dupe.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(tomica)
Resolution: --- → DUPLICATE

I likely messed up the fission flag while testing, this is not the same as bug 1646817, still need to figure out what it is.

There's a also a bug here about content scripts in iframes inside extension popups/sidebars, but I'm filing that as a separate bug.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Flags: needinfo?(kmaglione+bmo)
Assignee: nobody → kmaglione+bmo
Status: REOPENED → ASSIGNED
Flags: needinfo?(kmaglione+bmo)
Assignee: kmaglione+bmo → nobody
Status: ASSIGNED → NEW

Jim, this also looks related to bug 1672470. Please get this reviewed/triaged by the Graphics team too.

Component: General → Graphics
Product: WebExtensions → Core
Flags: needinfo?(jmathies)
Depends on: 1688096

I don't see a browser action button for this add-on.

Flags: needinfo?(jmathies)

My experience with the google translate add-on does not show the popup as shown in the reporter's video so I'm not able to verify the issue (Jim couldn't either).
Tom, can you confirm that you can see the issue and help the graphics team (jmathies) repro this and figure out the issue here?
Also, was the other issue (comment 4 and 5) addressed in a separate bug?

Flags: needinfo?(tomica)

Should be fixed by bug 1688096.

Assigning to aosmond (same as bug 1688096 assignee) so we don't have unassigned M6c bugs.

Assignee: nobody → aosmond
Attached video dRK70mhRca.mp4 (deleted) —

I tested it again and it seems to work now!

Only this issue still exists.

Flags: needinfo?(nkochar)

(In reply to kernp25 from comment #16)

I tested it again and it seems to work now!

Only this issue still exists.

Thank you very much :kernp25.

Jim, the remaining issue (comment 4 and comment 5) is for incorrect spacing. I'll unassign aosmond and move this to M7 (Fx88), Please find the correct assignee for it.

Assignee: aosmond → nobody
Fission Milestone: M6c → M7
Flags: needinfo?(tomica)
Flags: needinfo?(nkochar)
Flags: needinfo?(jmathies)

Changing the bug title as this is the only remaining issue.

Summary: web page loaded in iframe doesn't work in fission mode → [Fission] Incorrect spacing on the right in add-on
No longer depends on: 1688096
Component: Graphics → Graphics: WebRender
Flags: needinfo?(jmathies)

Jim, this is tracking Fission M7 (Fx88 - March 18). Can you please find an assignee for this so it can be fixed in time?

Flags: needinfo?(jmathies)

What is the add-on that has the problem?

Flags: needinfo?(kernp25)

Thanks.

I don't think this is a webrender or graphics issue. The layout of the contents of popup is different, this is probably either an issue for layout or the extension api?

Attached file addon.zip (deleted) —

Test add-on for bug 1656086.

I uploaded a test add-on. So you can reproduce the bug.

Flags: needinfo?(nkochar)

(In reply to Timothy Nikkel (:tnikkel) from comment #25)

Thank you for the simple addon.

Regression range
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88db9bea4580df16dc444668f8c2cddbb3414318&tochange=bbbe694dbff25ce304833a9c2f6520ba9f61fb32

Not sure what might have caused that in there. Read through that list one by one and I don't have a candidate to look at.

Thank you :kernp25 for the test add-on.
Moving to Layout component as the only remaining issue is the incorrect spacing.

Component: Graphics: WebRender → Layout
Flags: needinfo?(nkochar)
Flags: needinfo?(jmathies)

This bug has evolved quite a lot about what it's tracking.

For clarity, I'm going to file a new dedicated bug to cover the specific remaining layout issue here (which, by the way, I can reproduce by just directly loading the html testcase from the attached addon -- no addon-specific stuff is required on my machine)

Then we can close out this bug as a dupe of bug 1688096 (since that seems to have fixed the original/primary issue here, per comment 13 and comment 16.)

Adjusting bug summary to reflect the issue that was reported in comment 0 (which was fixed by bug 1688096), and duping to bug 1688096.

I've filed bug 1697890 to investigate the remaining issue with the blank space on the right.

Status: NEW → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → DUPLICATE
Summary: [Fission] Incorrect spacing on the right in add-on → [Fission] scrolling doesn't work in add-on

(In reply to Daniel Holbert [:dholbert] from comment #28)

Then we can close out this bug as a dupe of bug 1688096 (since that seems to have fixed the original/primary issue here, per comment 13 and comment 16.)

This makes me think there's still gfxVars::UseWebRender callsites which should be replaced by the information whether we really use WebRender or not in the window (bug 1684128). That said, I don't think it's worth spending time on that bug.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: