Closed Bug 1688096 Opened 4 years ago Closed 4 years ago

Use Software WebRender for popups when using Hardware Webrender on Windows

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Product:
Core
Component:
Graphics: WebRender
Platform:
All
Windows
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Project Flags:
Fission Milestone M7
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1688096 - Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors.
(deleted), text/x-phabricator-request
Details
Bug 1688096 - Part 2. Add flag to CompositorOptions to allow SW-WR on a per widget basis.
(deleted), text/x-phabricator-request
Details

We use basic for popups right now. It would be better if we used SW-WR. We should do this for anyone using SW-WR. Eventually we should consider doing this for HW-WR, but we'll use the SW-WR users as the test bed for this.

Andrew, do you expect to fix this bug to use SW-WR for popups before SW-WR rides the trains to Beta and Release?

This bug is breaking some WebExtensions popup UI when Fission is enabled: bug 1656086 and bug 1672470.

Blocks: 1656086, 1672470
Fission Milestone: --- → M6c
Flags: needinfo?(aosmond)
See Also: https://bugzilla.mozilla.org/show_bug.cgi?id=1672470 →

We're still determining our plans here. This bug is for that investigation.

Flags: needinfo?(aosmond)
No longer blocks: 1656086
Summary: Use Software WebRender for popups → Use Software WebRender for popups when using Hardware Webrender on Windows

Jeff and I chatted on Element. Jeff recommends that we defer this bug from M6c to M7. Of the bugs mentioned above as possibly related, both are M7. And bug 1656086 has been downgraded to just "incorrect spacing" (but still usable) and bug 1672470 is a test case with no known affected sites or extensions.

Fission Milestone: M6c → M7
OS: All → Windows
Attachment #9202645 - Attachment description: Bug 1688096 - Part 2. Add flag to CompositorOptions to allow SW-WR on a per widget basis. → Bug 1688096 - Part 2. Add/use flag to CompositorOptions to allow SW-WR on a per widget basis.
Blocks: 1693208
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6471b0910f45 Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/6cdfa0af2278 Part 2. Add/use flag to CompositorOptions to allow SW-WR on a per widget basis. r=mattwoodrow
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ad2f4d0c317 Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/aa0d1698aff8 Part 2. Add/use flag to CompositorOptions to allow SW-WR on a per widget basis. r=mattwoodrow
Attachment #9202645 - Attachment description: Bug 1688096 - Part 2. Add/use flag to CompositorOptions to allow SW-WR on a per widget basis. → Bug 1688096 - Part 2. Add flag to CompositorOptions to allow SW-WR on a per widget basis.
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b63a3c2fb751 Part 1. Merge SW-WR and WR render texture host paths to allow mixed compositors. r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/7e0fefcb981c Part 2. Add flag to CompositorOptions to allow SW-WR on a per widget basis. r=mattwoodrow

https://hg.mozilla.org/mozilla-central/rev/b63a3c2fb751
https://hg.mozilla.org/mozilla-central/rev/7e0fefcb981c

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1693619
Flags: needinfo?(aosmond)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: