Closed Bug 1656140 Opened 4 years ago Closed 4 years ago

WebExtensions tests failing on debug: browser_ext_windows.js, browser_ext_tabs_events.js, etc.

Categories

(Thunderbird :: Add-Ons: Extensions API, defect, P2)

defect

Tracking

(thunderbird_esr78 fixed, thunderbird80 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
thunderbird_esr78 --- fixed
thunderbird80 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: darktrojan)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Priority: P5 → P2

Some of these tests have always had problems with the main window's focus, especially since we hid the folder tree by default for some reason. I've used a variety of hacks to mitigate this, all of which I'm removing here, and replacing it with Services.focus.focusedWindow = window, which seems to work.

There's some failures I've never seen before on the Try run, but they went away on a retrigger, so I'm hoping it's just intermittent weirdness. Unrelated to this patch in any case.

Attachment #9166963 - Flags: review?(paul)
Comment on attachment 9166963 [details] [diff] [review] 1656140-webext-tests-focus-1.diff Review of attachment 9166963 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, and looks like a nicer way to handle this.
Attachment #9166963 - Flags: review?(paul) → review+
Target Milestone: --- → 81 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/106e9ab1abc4
Stop WebExtensions tests timing out at completion. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 9166963 [details] [diff] [review] 1656140-webext-tests-focus-1.diff This is only test code. Bug 1655892 exposed these failing tests.
Attachment #9166963 - Flags: approval-comm-esr78?
Attachment #9166963 - Flags: approval-comm-beta?

Comment on attachment 9166963 [details] [diff] [review]
1656140-webext-tests-focus-1.diff

[Triage Comment]
Approved for beta

Attachment #9166963 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9166963 [details] [diff] [review]
1656140-webext-tests-focus-1.diff

[Triage Comment]
Approved for esr78

Attachment #9166963 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: