Attach target and related thread from TargetList
Categories
(DevTools :: Framework, task, P1)
Tracking
(Fission Milestone:M6c, firefox81 fixed)
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In Bug 1633727, we moved attaching to target and thread from the debugger to the toolbox.
In the toolbox, it's done in the TargetList
's onTargetAvailable
callback.
This can be an issue because the toolbox TargetList instance is only one of the existing instances running for a given session, and could lead to races.
Moving the attaching phase directly to the TargetList itself would make it more safe, as all consumers could expect the targetList to be attached at the moment onTargetAvailable
is called.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c).
Comment 5•4 years ago
|
||
bugherder |
Comment 7•4 years ago
|
||
Sebastian let's back this out for the regressions please (also in beta) if we can't disable it.
Assignee | ||
Comment 8•4 years ago
|
||
We can probably disable the tests for now.
The failures are all from a specific area in the code, I'll try to go over it soon.
Description
•